Re: Sponsor needed for alberta package with soversion bump

[Pierre Gruet]

Hi MArkus,

Le 10/10/2024 à 14:29, Markus Blatt a écrit :

Thanks a lot for the review.
Am Sat, Oct 05, 2024 at 08:51:35PM +0200 schrieb Pierre Gruet:

Le 05/10/2024 à 15:17, Markus Blatt a écrit :

Thanks a lot for updating alberta!

Would be cool if somebody else would sponsor my changes. If I need to
make more changes to the package then please tell me so.

- some copyright holders are missing:
$ grep -r "Copyright" ./* | grep -v -e "debian"

I reviewed the package and have some questions/remarks. Only the first ont /has/ to be addressed before uploading to NEW. shows the names of Universitaet Freiburg, Universitaet Bonn, Hiroshi Nakashima, Markus Kohm, Radical Eye Software. Could you please update thoroughly d/copyright?

Uni Bonn is below add_ons/grape which is deactivated for Debian with
--without-grape.
Kohm Nakashima and Radical Eye have copyright in doc. That is also not part
of any binary package currently.

Hence I think copyright is actually fine.

Thanks for having worked again on the package.



Tell me if you need help to address this.

Well, it might not be embedded in a binary package but it still belongs to the source package, which others might download, redistribute... Thus d/copyright has to list such files, all the more so since it will be reviewed manually when going through NEW. We either need to add the copyright holders in d/copyright or to repack to remove unused source files.

- Following Lintian: no need to set DEB_HOST_ARCH in d/rules, including /usr/share/dpkg/architecture.mk is enough - d/libalberta5.lintian-overrides can now be removed, it overrides nothing.

Done.

- Do you know why the Salsa repo holds only the debian/ directory and not the whole source?

I am not sure. Maybe for historical reasons, e.g. when packaging started
upstream might not have used git yet, but packaging did.

Do think we should change that and move e.g. to the git-buildpackage approach?

        https://science-team.pages.debian.net/policy/#idm297
encourages this.

This is /my/ personal preference, but I don't mean to make it an obligation. I would say the Policy of debian-science

I have pushed my changes to salsa

[1] https://salsa.debian.org/science-team/alberta

If I need to do more then please let me know.
Thanks a again for investing the time to sponsor this.

And thanks for the work on alberta!

Best,

Markus

Kind regards,

--
Pierre

OpenPGP_signature.asc
Description: OpenPGP digital signature