On 20/11/2025 22:05, Thomas Schmitt wrote:
Max Nikulin wrote:
Instead of manual "ln", looking into /lib/udev/rules.d/60-cdrom_id.rules, I
expect something like (untested, I do not have an optical drive)

SUBSYSTEM=="block", KERNEL=="sr[0-9]*", ENV{DEVTYPE}=="disk",
ACTION!="remove", SYMLINK+="scd%n"

in /etc/udev/rules.d/

This would indeed be preferrable, because it automagically creates
the symlinks as drives appear.

Has anybody tried that it works as expected?

<https://salsa.debian.org/debian/cdrkit>

So it is suitable only for patches.

I am afraid, there is nothing else, otherwise it would be mentioned in debian/control

I wonder by which channel this patch came in:

   "isoinfo: support EFI architectur"
   "Heinrich Schuchardt authored Mar 08, 2025 and Andreas Beckmann's
    committed Sep 28, 2025"

I think, it is a cherry-pick of
<https://salsa.debian.org/debian/cdrkit/-/merge_requests/1>

I have not tried to compare if changes are exactly the same. (Then why it is not just merged? Is it an issue with target branch?)

+        return ( 0==uname( &buf ) && sscanf(buf.release, "%d.%d", &gen, &tmp)>1 && 
(gen>2 || tmp>=6));

This one would return 1 with 1.6 or higher. But
   https://en.wikipedia.org/wiki/Linux_kernel_version_history
says that kernel 1.x ended at 1.3.100.

I would prefer explicit comparison. I would even change default return value in the case of failure

return 0 != uname(&buf)
   || 2 != sscanf(buf.release, "%d.%d", &major, &minor)
   || major > 2
   || (major == 2 && minor >= 6)

However since it was for renaming to scd<N>, I am not sure that conditions should not be modified for sr<N>. This uncertainty at least deserves a comment.

In libusal/scsi-linux-sg.c, usalo_open(), line 532:

-                                               pattern="/dev/scd%d";
+                                               pattern="/dev/sr%d";

My opinion is that "scd" should remain at least in comments just to document that it existed. I would even consider a dead branch of code, but others may object.

On the BurnCD wiki page I noticed a link to the following message:

<https://lists.debian.org/msgid-search/[email protected]>
Steve McIntyre to debian-user.
Re: How to react on a factually wrong Debian wiki change ?
Fri, 28 Sep 2018 18:49:26 +0100:

cdrkit is definitely now EOL, and I don't use it
myself for writing DVD or BD media.

"EOL" is not encouraging.

Reply via email to