On 01/07/14 17:39, intrigeri wrote: > Great that you added DEP-3 headers. I'm not sure if the "This patch > header follows DEP-3" notice is useful, though.
This is automatically added by `dquilt header --dep3` so I stuck with it. >> The only two left IMO are false positives: > >> - debian-watch-file-is-missing: currently N/A, upstream does not release the >> tarballs >> separately outside of git tags. I work closely enough with upstream that >> it's not so >> important anyways. > >> - using-first-person-in-description: does not exactly apply, "we" used here >> is descriptive and neutral rather than instructive. > > Fair enough. Please add overrides that explain this as > a comment, then. > I eventually decided to just add the watch file, but overriding the first-person would require 5 override files. >>> 5. We don't ship software in Debian that has dependencies outside >>> Debian to be useful at all. So, in the current state of things, the >>> node-flashproxy binary package (and its README.Debian) is a no-no. >>> Time to ping Mike Gabriel on #721558 (and offer your help if you >>> wish), perhaps. >>> This is now in NEW: https://ftp-master.debian.org/new/node-ws_0.4.30-1.html >>> 12. I have not tested the resulting binary packages with piuparts. >>> I suggest you do it if you can afford it: discovering issues >>> before the QA team knocks at the door is nicer both for them, and >>> for you :) >>> I've now verified everything with both piuparts and pbuilder and everything is OK. Though piuparts should actually be failing since node-ws is not installable yet, they have a bug for that already: #718544. Package built here: -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20140118013139.168...@gmx.com