You are right about sd-daemon.[ch] file, I forgot about it. I think I can remove it as its included in libsystemd-daemon-dev. I add the bug to the onion issue tracker to do it asap.
The proper license for src (except that files) is both GPLv2 and Apache2. I just changed the README.rst. 2014-04-24 18:19 GMT+02:00 László Böszörményi (GCS) <g...@debian.org>: > On Thu, Apr 24, 2014 at 5:40 PM, David Moreno Montero > <dmor...@coralbits.com> wrote: > > If you agree, you may branch the onion source at github, and pull > request me the changes. > OK, will do. > > > About jquery, is it ok to include it non-minified? Also could be used > straight from the jquery CDN, but somehow I feel users would feel more > secure if its using only local resources. > Better if not. 1) Not all users will have internet access for CDN. 2) > jQuery may have performance / security issues anytime. Just depend on > the needed version, as it's already packaged and taken care of. > > > About library versioning, I just added it, but I got a bug report that > its not following proper libtool standards. I'm still fixing that, but the > current solution should be on the debian branch. > OK, waiting for that. > > > About manpages, I can try to prepare them ASAP, but some tips are > welcome about how to create great manpages: which programs/commands? is > groff the recomended way? > For a start you may use 'apt-get install help2man; man help2man'. > > One more problem btw. LICENSE.txt states: "Contents of the src folder > (the Library) is licensed under both GPLv2+ and Apache 2." while > README.rst states: "The library is under the LGPL license, [...]" > (which one?), then see a file, for example src/onion/block.c which has > only Apache 2.0 license header. Which one is correct? Then you link > together everything with src/onion/sd-daemon.[ch] which is licensed > under MIT. I'm not a license expert and don't know what the result > will be. Does linking MIT with (L)GPL code allowed? Where's / how MIT > license vanished from the resulting library? > > Laszlo/GCS > -- David Moreno Montero dmor...@coralbits.com +34 658 18 77 17 +44 74 23 21 01 57 <http://www.coralbits.com/> http://www.coralbits.com
