On May 2, 2011, at 8:30 PM, Alfredo Moralejo wrote:

Hi,

> Hi,
> 
> I've found a rproblem with vm name when using deltacloud with condor as 
> condor uses condor GlobalJobId as vm name what is too long for RHEV.
> 
> This patch was already aplied in revision 1089029 but was removed later. This 
> patch uses only the last part of the GlobalJobId for vm name:

I removed that because I though that it's a bug in Aeolus/Conductor (using full 
GlobalJobID as an instance name probably
isn't a good idea...). 

But if it's a problem I can add this 'hotfix' back or just trim name string to 
fix 50 characters.

  -- Michal

> 
> Index: lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> ===================================================================
> --- lib/deltacloud/drivers/rhevm/rhevm_driver.rb    (revision 1098668)
> +++ lib/deltacloud/drivers/rhevm/rhevm_driver.rb    (working copy)
> @@ -169,7 +169,9 @@
>     client = new_client(credentials)
>     params = {}
>     safely do
> -      params[:name] = opts[:name] if opts[:name]
> +      # FIXME: Condor is using GlobalJobId here as a name, which is malformed
> +      # and contains >50 characters
> +      params[:name] = opts[:name].split("#").last if opts[:name]
>       params[:realm_id] = opts[:realm_id] if opts[:realm_id]
>       params[:hwp_id] = opts[:hwp_id] if opts[:hwp_id]
>       params[:hwp_memory] = opts[:hwp_memory] if opts[:hwp_memory]
> 
> Regards,
> 
> Alfredo Moralejo

----------------------------------------------------------------------
Michal Fojtik, Software Engineer, Red Hat Czech
[email protected]
Deltacloud API: http://deltacloud.org

Reply via email to