Hi,

Probably you are right, and the best place to fix it is in conductor (in fact I think the problem is in deltacloud job in condor that is part of condor, not conductor ).

I've filled a bz for conductor https://bugzilla.redhat.com/show_bug.cgi?id=701441.

Best regards,

Alfredo





On 05/02/2011 10:06 PM, Michal Fojtik wrote:
On May 2, 2011, at 8:30 PM, Alfredo Moralejo wrote:

Hi,

Hi,

I've found a rproblem with vm name when using deltacloud with condor as condor 
uses condor GlobalJobId as vm name what is too long for RHEV.

This patch was already aplied in revision 1089029 but was removed later. This 
patch uses only the last part of the GlobalJobId for vm name:
I removed that because I though that it's a bug in Aeolus/Conductor (using full 
GlobalJobID as an instance name probably
isn't a good idea...).

But if it's a problem I can add this 'hotfix' back or just trim name string to 
fix 50 characters.

   -- Michal

Index: lib/deltacloud/drivers/rhevm/rhevm_driver.rb
===================================================================
--- lib/deltacloud/drivers/rhevm/rhevm_driver.rb    (revision 1098668)
+++ lib/deltacloud/drivers/rhevm/rhevm_driver.rb    (working copy)
@@ -169,7 +169,9 @@
     client = new_client(credentials)
     params = {}
     safely do
-      params[:name] = opts[:name] if opts[:name]
+      # FIXME: Condor is using GlobalJobId here as a name, which is malformed
+      # and contains>50 characters
+      params[:name] = opts[:name].split("#").last if opts[:name]
       params[:realm_id] = opts[:realm_id] if opts[:realm_id]
       params[:hwp_id] = opts[:hwp_id] if opts[:hwp_id]
       params[:hwp_memory] = opts[:hwp_memory] if opts[:hwp_memory]

Regards,

Alfredo Moralejo
----------------------------------------------------------------------
Michal Fojtik, Software Engineer, Red Hat Czech
[email protected]
Deltacloud API: http://deltacloud.org



--

Alfredo Moralejo
Red Hat - Senior Consultant
RHCE, RHCVA, RHCA

Office: +34 914148838
Cell: +34 607909535
Email: [email protected]

Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain
Dirección Registrada: Red Hat S.L., C/ Velazquez 63, Madrid 28001, Spain
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941

Reply via email to