+0: agree on the conventions, but I believe that we should expand with provisions about import structure:
a) provision of 'no unused imports' b) provisions on import ordering e.g requesting something like: import statics; import java....; import javax......; import others; import org.deltaspike; Note that actual structure would be TBD, this is just a suggestion. The benefit to have a well-established import structure is that it further minimizes diffs introduced by various ways of adding imports (autocomplete, auto-import, manual, etc). On 2011-12-17, at 7:58 PM, Gerhard Petracek wrote: > Hi, > > I asked [1] to add alternative settings to DELTASPIKE-12, since we have > seen several different opinions (about details). > Nobody added an alternative set. So I start the formal vote with the > suggested set right now. > If we don't see a majority, we have to re-visit this topic again (+ we > would need a new vote with at least one concrete alternative). > > Please review the coding conventions at [2] and vote. > (Its content is also included below for your convenience). > > ------------------------------------------------ > [ ] +1 I'm ok with the coding conventions > [ ] +0 > [ ] -1 I've major objections, because... > ------------------------------------------------ > > The vote is open for 72 hours. > > Thanks, > Gerhard > > [1] http://s.apache.org/Ga8 > [2] http://s.apache.org/SAj > > --- > > 1) no tabs, only spaces (4 spaces). > 2) bracelets on new line > 3) force bracelets > 4) 4 spaces indent size > 5) a space between keyword and round bracket > 6) a space before and after an operand > 7) line width: 120 > 8) no underscore at the beginning > 9) no wildcard imports
