#1931: No warning when binding to configured listening port fails
-----------------------+----------------------------------------------------
Reporter: OmegaPhil | Owner:
Type: bug | Status: new
Priority: minor | Milestone: 1.4.0
Component: gtkui | Version: git master
Keywords: |
-----------------------+----------------------------------------------------
Comment(by andar):
Good work.
Unfortunately I don't think I'd accept this patch as-is. There is too
much repetition that needs to be re-factored.
I think that we should probably add some sort of ListenOnEvent that gets
sent when the associated libtorrent alert happens. We could have the
gtkui watch for this event and do its checks to see if the port is within
the desired range. This, however, does not solve the need to check upon
start of the gtkui. I suppose this could happen roughly the same way
you're doing it directly from gtkui.py but it should probably call out to
some shared code to do the check and the popup message so that the code is
not duplicated.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1931#comment:2>
Deluge <http://deluge-torrent.org/>
Deluge project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/deluge-dev?hl=en.
