#2116: Application layer protocol for transfering RPC messages + utf8 decoding
error
-------------------+--------------------------------------------------------
Reporter: bro | Owner:
Type: patch | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.5
Keywords: |
-------------------+--------------------------------------------------------
Comment(by andar):
Thank you for the effort in putting this together! You even included
tests ;)
I do have some comments:
I am not quite sure why we would never be able to properly decompress the
message after getting all of the it into the buffer.. But it definitely is
a bit of a design flaw in terms of computation required to constantly try
decompressing on an incomplete message especially if they are quite large.
The message length header is reasonable and I think that should probably
be committed into master. The code looks nice and clean with comments and
documentation, so again, thank you for that!
The second problem with rencode is something that I would like to look
into more.. Moving to pickle isn't really an option due to the security
implications of pickle - I'm sure you can do some googling to find out all
the reasons, but it essentially boils down to being able to pickle
(mostly) any object type, including those that could run malicious code.
This was one of the primary reasons I chose to use rencode since it is
relatively quick and only functions on the basic types required.
Have you tried my enhanced rencode module?
http://code.google.com/p/rencode/
I'd be really interested if it solves your problem. It is also a lot
quicker than the Python version included with Deluge. Perhaps we should
look into including this module instead of the current pure-Python
version.
If it doesn't solve your problem, we should figure out where it's
occurring and correct it.. I suspect we might be able to do something in
the Protocol to check for invalid string types before doing an rencode.
An updated patch to remove the pickle stuff and just include the message
length header would be nice.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2116#comment:2>
Deluge <http://deluge-torrent.org/>
Deluge project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/deluge-dev?hl=en.
