#2116: Application layer protocol for transfering RPC messages + utf8 decoding
error
-------------------+--------------------------------------------------------
Reporter: bro | Owner:
Type: patch | Status: new
Priority: major | Milestone: Future
Component: other | Version: 1.3.5
Keywords: |
-------------------+--------------------------------------------------------
Comment(by bro):
Replying to [comment:5 andar]:
> Could you please rebase your patch against the HEAD of master? I think
your patch has been based off the 1.3-stable branch.
https://github.com/bendikro/deluge/tree/master-dev
I added some tests on the header of the incoming data.
I've barely tested the patch on the master branch as I had some problems
loading the old torrents. When starting deluged on my server the torrents
are loaded according the log, but the message with the torrents (the 1600)
is never sent to the client. Is it so that torrents from 1.3.5 won't load
on current master?
As for how to fix the rencode issue, as you already wrote, Deluge should
always pass utf8 strings, so I guess that should be fixed no matter.
A problem with not changing rencode is that the same issue might appear
with some other strings that Deluge (or some plugin?) doesn't handle
properly?
Pickle did work with no problems when I tested, so I doubt there would be
any major problems with changing rencode. Still it's best to be certain
before changing rencode in Deluge ;-)
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2116#comment:6>
Deluge <http://deluge-torrent.org/>
Deluge project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/deluge-dev?hl=en.
