Markus M. May wrote:

--- snip ---


I am getting (finally) closer to being able hack this code agian. My
thinking is we associate MD5 checksum files URLs with files URLs (as
attributes), and when we decide to download one we (1) copy to an unsafe
place (2) check the checksum against that one (3) move if ok (4) fail
[exception] if not.


[snip]

Hello Adam, I think (4) should be something like: the user can decide (via a
property or via an question, if the build fails or the build continues.


Why? If the checksum does not match the jar, something is wrong:
1 communication error during download caused jar or checksum to be corrupted
2 jar or checksum replaced using "man in the middle" attack during download
3 jar or checksum is corrupted on website
4 wrong jar or checksum on site


[1] is the most likely.  The only other sensible things to do might be to:
 * send an error report back to Apache
 * try again (perhaps try up to 3 times?)

--
Michael



Reply via email to