Re: [PATCH] Change all Identifier Limitations to 128

[Lance J. Andersen]

Hi Phillipp,
Unless i misread the diffs, it looks like there are still some 
references to DB2Limit and constants with DB2_ as the prefix.

Here are a couple of examples.
Index: java/engine/org/apache/derby/impl/sql/compile/CreateAliasNode.java
===================================================================
--- java/engine/org/apache/derby/impl/sql/compile/CreateAliasNode.java  
(revision 111709)
+++ java/engine/org/apache/derby/impl/sql/compile/CreateAliasNode.java  
(working copy)
@@ -28,7 +28,7 @@
import org.apache.derby.iapi.sql.compile.C_NodeTypes;
import org.apache.derby.iapi.reference.SQLState;
-import org.apache.derby.iapi.reference.DB2Limit;
+import org.apache.derby.iapi.reference.DerbyLimit;
import org.apache.derby.iapi.sql.ResultSet;
import org.apache.derby.iapi.sql.execute.ConstantAction;
@@ -126,9 +126,9 @@
                                TypeDescriptor[] types = null;
                                int[] modes = null;
-				if (paramCount > DB2Limit.DB2_MAX_PARAMS_IN_STORED_PROCEDURE)
+				if (paramCount > DerbyLimit.DB2_MAX_PARAMS_IN_STORED_PROCEDURE)
					throw StandardException.newException(SQLState.LANG_TOO_MANY_PARAMETERS_FOR_STORED_PROC,
-							String.valueOf(DB2Limit.DB2_MAX_PARAMS_IN_STORED_PROCEDURE), aliasName, String.valueOf(paramCount));
+							String.valueOf(DerbyLimit.DB2_MAX_PARAMS_IN_STORED_PROCEDURE), aliasName, String.valueOf(paramCount));
 

Is there a reason that this is still DB2_MAX_PARAMS?
	/* identifier() used to be columnName() */
-	//unqualified column names are limited to 30 characters
-	columnName = identifier(DB2Limit.DB2_MAX_IDENTIFIER_LENGTH30, true) 
+	//unqualified column names are limited to 128 characters
+	columnName = identifier(DB2Limit.DB2_MAX_IDENTIFIER_LENGTH128, true) 
		( typeDescriptor = dataTypeDDL() 
		)
	[ defaultNode = defaultAndConstraints(typeDescriptor, tableElementList, columnName, autoIncrementInfo) ]
@@ -4115,7 +4115,7 @@
		//limit the qualifiedId to the id length limit passed to this method
		checkIdentifierLengthLimit(qualifiedId, id_length_limit);
		if (schemaName != null)
-			checkIdentifierLengthLimit(schemaName, DB2Limit.DB2_MAX_IDENTIFIER_LENGTH30);
+			checkIdentifierLengthLimit(schemaName, DB2Limit.DB2_MAX_IDENTIFIER_LENGTH128);
 

DB2Limit is still the class name
Regards
Lance