It does no longer throw an NPE, and it passes all tests....
Could we leave EmbeddedDataSource alone & only change EmbeddedXADataSource? Only with the xa datasource did we get a NPE...
Although strictly speaking, it should behave the same, so, with EmbeddedDataSource too, we should accept the databasename only, it's been able to resolve the url fine. I'd be apprehensive about any possible cloudscape customers that have mistakenly used this functionality...
Myrna
Shreyas Kaushik wrote:
Any comments/updates on this?
thanks Shreyas
Shreyas Kaushik (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-95?page=comments#action_57577 ]
Shreyas Kaushik commented on DERBY-95:
--------------------------------------
Attaching the latest patch as per Dan's comments so that the getConnection() method in EmbeddedDataSource does not return null. It will throw a SQLException if the driver is not able to connect to the database.
Also attaching the latest diff.
NPE when passing in url instead of database name to EmbeddedXADataSource
------------------------------------------------------------------------
Key: DERBY-95 URL: http://issues.apache.org/jira/browse/DERBY-95 Project: Derby Type: Bug Components: JDBC Reporter: Myrna van Lunteren Priority: Minor Fix For: 10.0.2.1 Attachments: Derby-95.diff, Derby-95_latest.diff
When passing in a url (e.g. jdbc:derby:mydb) instead of just the database name (e.g. mydb) the XADataSource gives a NullPointerException.
It should either handle this a little more gracefully & give an error, or accept the url (like EmbeddedDataSource does).
