Waiting 1 day and no error was found. Can I ask committers to commit this patch ?
Or I should commit it by myself ?
Best regards.
/*
Tomohito Nakayama
[EMAIL PROTECTED]
[EMAIL PROTECTED] Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html*/
----- Original Message ----- From: "Jack Klebanoff" <[EMAIL PROTECTED]>
To: "Derby Development" <[email protected]>
Sent: Tuesday, March 29, 2005 4:31 AM
Subject: Re: [Patch] Re: About improvement of DERBY-134
TomohitoNakayama wrote:
Hello.
I have added some test to orderby.sql (and correspond result to orderby.out) ,
which was suggested by Jack Klebanoff.
And I have executed derbylang test and coulud not found error exept for lang/floattypes.sql.
I think this error is not caused by my patch.
derbylang_report.txt is attached to this mail.
Please check this patch from a point of other person's view.
best regards.
/*
Tomohito Nakayama [EMAIL PROTECTED] [EMAIL PROTECTED]
Naka http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
The latest patch looks good to me. I looked at the changes, applied the patch to recently updated Derby source, and successfully ran the derbylang test suite. (I did not even see the failure in lang/floattypes.sql that Tomohito saw. It was probably fixed in Derby updates I picked up today).
Jack Klebanoff
-- No virus found in this incoming message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.8.4 - Release Date: 2005/03/27
-- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.8.4 - Release Date: 2005/03/27
