The wrong overload of StandardException::newException() is used in some cases
-----------------------------------------------------------------------------
Key: DERBY-336
URL: http://issues.apache.org/jira/browse/DERBY-336
Project: Derby
Type: Bug
Environment: Any
Reporter: Dyre Tjeldvoll
Assigned to: Dyre Tjeldvoll
Priority: Trivial
When looking at DERBY-128 it became clear that the wrong overload of
StandardException::newException() was used when reporting
SQLState.SERVICE_DIRECTORY_CREATE_ERROR. The message string only takes one
parameter so only one additional parameter (other than Throwable) should be
used:
PersistentServiceImpl.java:676
throw
StandardException.newException(SQLState.SERVICE_DIRECTORY_CREATE_ERROR,
serviceDirectory, null);
// Calls StandardException.newException(String, Object, Object)
// Should call StandardException.newException(String, Object)? Or
StandardException.newException(String, Throwable, Object)? With the IOException
as
// Throwable?
PersistentServiceImpl.java:692
throw
StandardException.newException(SQLState.SERVICE_DIRECTORY_CREATE_ERROR, name,
t);
// Calls StandardException.newException(String, Object, Object)
// Should call StandardException.newException(String, Throwable, Object)?
BaseDataFileFactory.java:279
throw StandardException.newException(
SQLState.SERVICE_DIRECTORY_CREATE_ERROR, dataDirectory, ioe);
// Calls StandardException.newException(String, Object, Object)
// Should call StandardException.newException(String, Throwable, Object)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
