This looks good. +1 to commit the patch. The message you forwarded seems to be for another bug. I reviewed Derby-287 doc change, not the Derby-243 in the 'Original Message'. Hope this is what you wanted.
Satheesh Jean T. Anderson wrote: > Mamta requested that somebody else review this patch, so I thought I'd > try Kathey's CPR approach (see below) and nag somebody specific -- > Satheesh. :-) Of course, Satheesh should feel free to say "nope! sorry > -- can't!" > > At any rate, I took a pass through the open doc bugs to see if any can > be cleared out while Jeff is on vacation and DERBY-287 looks like the > only candidate so far. > > -jean > > -------- Original Message -------- > Subject: Re: [jira] Updated: (DERBY-243) connection toString should > uniquely identify the connection > Date: Tue, 31 May 2005 13:22:00 -0700 > From: Kathey Marsden <[EMAIL PROTECTED]> > To: Derby Development <[email protected]> > > > David Van Couvering wrote: > > > we really need somebody else to review and test it. So far no > > volunteers. > > > I think I've come to the conclusion that it's a little like they tell > you in CPR training. Instead of "Can somebody call 911?" , you say, > "You, call 911!" Then if they say no you find someone else. > > I've abandoned: > > "Can someone please review/test this patch?" > > in favor of > > "<name> , can you please review/test this patch?" > > > Kathey > > > > > > > > > > > > >
