Daniel John Debrunner wrote: > [EMAIL PROTECTED] wrote: > > [on comments about re-use of TimerTasks] > write a comment about this in the code in a subsequent > >>patch (for instance when implementing Statement.cancel), unless anybody >>wants me to address this now and submit a new patch. > > > I think delaying the comment is fine. > > I'm planning to commit this change before the end of this week, assuming > all the tests run for me.
I had to re-run the tests because the patch messed up on one file, but now StmtCloseFunTest fails for me with this patch. *** Start: StmtCloseFunTest jdk1.4.2 derbyall:jdbc20 2005-06-28 22:08:57 *** 2a3 > Statement Test failed (10) 4a6 > Prepared Statement Test failed 7a10 > Callable Statement Test failed Test Failed. *** End: StmtCloseFunTest jdk1.4.2 derbyall:jdbc20 2005-06-28 22:09:05 *** I'll look into it, but is anyone else seeing this failure? Dan.
