[ 
http://issues.apache.org/jira/browse/DERBY-453?page=comments#action_12316000 ] 

Kathey Marsden commented on DERBY-453:
--------------------------------------

I spoke with Deepa off-line about this and had a few comments on the patch.  

I  think  the wrapper function for getBigDecimal by 
columnname,canConvertToDecimal,   should take a columnname parameter rather 
than  getting it in the method just for the sake of clarity in the tests.

I think it would be good to have a class comment with the summary of the 
handling of BigDemcimal values in J2ME and an explanation of how tests that use 
BigDecimal values should be written so that they work with J2ME.

I am not really comfortable with the mock up of data conversion exceptions for 
J2ME but don't really have a better idea #:).
Need to check the types listed in canConvertToDecimal.  I think some of them 
are not quite right.



> Create a test wrapper to run tests using BigDecimal in J2ME/CDC/Foundation
> --------------------------------------------------------------------------
>
>          Key: DERBY-453
>          URL: http://issues.apache.org/jira/browse/DERBY-453
>      Project: Derby
>         Type: Improvement
>   Components: Test
>  Environment: J2ME/CDC/Foundation using IBM's WCTME 5.7
>     Reporter: Deepa Remesh
>     Assignee: Deepa Remesh
>     Priority: Minor
>  Attachments: derby-453.diff, derby-453.status
>
> The following tests are currently excluded in J2ME/CDC/Foundation because 
> they use BigDecimal class. 
> I18NImportExport
> batchUpdate
> LOBTest
> parameterMapping
> resultset
> StmtCloseFunTest
> cast
> functions
> outparams
> procedure
> triggerRefClause
> wisconsin
> iepnegativetests
> ieptests
> importExportThruIJ
> importExport
> To run the above tests in this environment, test utility classes have to be 
> written so that the methods using BigDecimal are redirected depending on the 
> VM environment. The initial goal is to submit a patch for the test 
> resultset.java. After this, sub-tasks will be opened if changes are needed to 
> run the other tests.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to