[ http://issues.apache.org/jira/browse/DERBY-530?page=comments#action_12323230 ]
Deepa Remesh commented on DERBY-530: ------------------------------------ I ran derbyall with this patch and got two failures: * derbyall/derbynetclientmats/derbynetmats.fail:jdbcapi/checkDriver.java * derbyall/derbynetmats/derbynetmats.fail:jdbcapi/checkDriver.java I think new master files have to be created for DerbyNet and DerbyNetClient frameworks because of addition of tests for Client attributes. I looked at the changes and I have one comment on one of the comments in the code. The comment for 'tokenizeDatabase' method in ClientDriver.java can be changed from "//return database name and attributes" to "//return database name". With the changes for DERBY-530, it only returns the databaseName. Currently in jdbcapi/checkDriver.java, I see tests only for 'traceFile' property in 'testClientAttributes'. I think it would be good to test some more properties using the Properties object. > ClientDriver ignores Properties object in connect(String url, Properties > connectionProperties) method > ----------------------------------------------------------------------------------------------------- > > Key: DERBY-530 > URL: http://issues.apache.org/jira/browse/DERBY-530 > Project: Derby > Type: Bug > Components: Network Client > Versions: 10.1.1.0 > Environment: windows XP, JRE 1.5.0_04 > Reporter: Piet Blok > Assignee: Kathey Marsden > Attachments: DERBY530.diff > > In contrast to EmbeddedDriver, a connection attribute create=true is not > recognized when presented as a property in a Properties object. > As a workaround I append the attributes from the Properties object to the > url string before invoking the connect() method: then a new database is > created and a connection is established. > Next code fragment illustrates the bug and the workaround: > private static final ClientDriver clientDriver = new ClientDriver(); > private Connection getClientConnection(String database, > Properties connectionProperties) throws SQLException { > try { > System.out.println("Try to connect with properties"); > String connectionURL = "jdbc:derby://127.0.0.1:1527/" + database; > System.out.println("connectionURL: " + connectionURL); > Connection rv = clientDriver.connect(connectionURL, > connectionProperties); > System.out.println("Connection: " + rv); > return rv; > } catch (SQLException e) { > System.out.println("Try to connect with URL attributes"); > StringBuffer sb = new StringBuffer(); > for (Enumeration enu = connectionProperties.propertyNames(); enu > .hasMoreElements();) { > String key = (String) enu.nextElement(); > sb.append(';'); > sb.append(key); > sb.append('='); > sb.append(connectionProperties.getProperty(key, "")); > } > String connectionURL = "jdbc:derby://127.0.0.1:1527/" + database > + sb.toString(); > System.out.println("connectionURL: " + connectionURL); > Connection rv = clientDriver.connect(connectionURL, > connectionProperties); > System.out.println("Connection: " + rv); > System.out > .println("!!!!!!!!!!! seems a bug: Properties argument in > ClientDriver.connect(String, Properties) has not been used"); > return rv; > } > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
