[
https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617184#comment-13617184
]
Dag H. Wanvik edited comment on DERBY-6125 at 3/30/13 5:34 AM:
---------------------------------------------------------------
Committed derby-6125-02-a as svn 1462394.
Uploading derby-6125-03-a. This patch
- makes a mutable public array (dncPackageConsistencyToken) private.
- removes a couple of assignment with values that are never used (e.g. myPVH)
- makes some members final and public
- reworks an invariant to use SanityManager assert
- replaces a StringBuffer with StringBuilder
- makes a lazy initialization thread safe (codePointNameTable__)
- removes a couple of noop bit operations
- removes an unused method (computeDncLogWriter with existing connection
overload)
Running regressions [Update: passed]
was (Author: dagw):
Committed derby-6125-02-a as svn 1462394.
Uploading derby-6125-03-a. This patch
- makes a mutable public array (dncPackageConsistencyToken) private.
- removes a couple of assignment with values that are never used (e.g. myPVH)
- makes some members final and public
- reworks an invariant to use SanityManager assert
- replaces a StringBuffer with StringBuilder
- makes a lazy initialization thread safe (codePointNameTable__)
- removes a couple of noop bit operations
- removes an unused method (computeDncLogWriter with existing connection
overload)
Running regressions
> Code clean up in client driver.
> -------------------------------
>
> Key: DERBY-6125
> URL: https://issues.apache.org/jira/browse/DERBY-6125
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Reporter: Dag H. Wanvik
> Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff,
> derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status,
> derby-6125-03-a.diff, derby-6125-03-a.status
>
>
> Clean up unused code, lacking finals, too wide visibility etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
