[
https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618020#comment-13618020
]
Dag H. Wanvik edited comment on DERBY-6125 at 3/30/13 8:40 AM:
---------------------------------------------------------------
Uploading patch derby-6125-04-a which builds on the uncommitted
derby-6125-03-a. Patch details:
Patch details:
- removed unused var Configuration.traceFileSuffixIndex__,
#enableConnectivityToTargetServer__, #jvmSupportsMicrosClock
- made #dncCompatibleJREVersions private, added "1.8" as a legal JRE, and added
accessor getDncCompatibleJREVersions
- made NetConnection#msgutil final
- removed unused var targetExtnam_
- made #indoubtTransactions_ private and changed to genericized HashMap, I
believe this is multi thread safe, being used within a XA connection. Added
accessors #getIndoubtTransaction and #getIndoubtTransactionIds
- made some methods final (e.g. #completeConnect, #flowConnect,
#flowSimpleConnect, #isConnectionNull)
- removed unused extnam
- reduced some variable's scopes to silence FindBugs.
- made #targetPublicKey_ private, changed accessor #getTargetPublicKey to copy
the the mutable array's contents
- removed instances of useless code of this shape:
:
if (!isXAConnection_)
return;
if (isOpen()) { // <--- has no side effects
return; // still open, return
}
} <---- we return here anyway...
- removed unused vars NetConnectionReply#srvdgnReceived, #srvdgn
- replaced StringBuffer with StringBuilder in
NetConnectionReply#doMgrlvlrmSemantics
- removed unused var NetXAResource#numXid
- removed unused var ClientBaseDataSourceRoot#globaltraceFileSuffixIndex
was (Author: dagw):
Uploading patch derby-6125-04-a which builds on the uncommitted
derby-6125-03-a. Patch details:
Patch details:
- removed unused var Configuration.traceFileSuffixIndex__,
#enableConnectivityToTargetServer__, #jvmSupportsMicrosClock
- made #dncCompatibleJREVersions private, added "1.8" as a legal JRE, and added
accessor getDncCompatibleJREVersions
- made NetConnection#msgutil final
- removed unused var targetExtnam_
- made #indoubtTransactions_ private and changed to genericized HashMap, I
believe this is multi thread safe, being used within a XA connection. Added
accessors #getIndoubtTransaction and #getIndoubtTransactionIds
- made some methods final (e.g. #completeConnect, #flowConnect,
#flowSimpleConnect, #isConnectionNull)
- removed unused extnam
- reduced some variable's scopes to silence FindBugs.
- made #targetPublicKey_ private, changed accessor #getTargetPublicKey to copy
the the mutable array's contents
- removed instances of useless code of this shape:
:
if (!isXAConnection_)
return;
if (isOpen()) { // <--- has no side effects
return; // still open, return
}
} <---- we return here anyway...
- removed unused vars NetConnectionReply#srvdgnReceived, #srvdgn
- replaced StringBuffer with StringBuilder in
NetConnectionReply#doMgrlvlrmSemantics
- removed unused var NetXAResource#numXid
- removed unused var ClientBaseDataSourceRoot#globaltraceFileSuffixIndex
> Code clean up in client driver.
> -------------------------------
>
> Key: DERBY-6125
> URL: https://issues.apache.org/jira/browse/DERBY-6125
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Reporter: Dag H. Wanvik
> Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff,
> derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status,
> derby-6125-03-a.diff, derby-6125-03-a.status
>
>
> Clean up unused code, lacking finals, too wide visibility etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
