[
https://issues.apache.org/jira/browse/DERBY-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-6169:
--------------------------------------
Attachment: derby-6169-10-a.diff
Attaching derby-6169-10-a.diff which fixes the mistake from the 07-a patch by
removing the presumably dead code.
The patch removes both CreateViewNode.getProviderInfo() and the code that calls
it in BasicDependencyManager.coreInvalidateFor(). An assert has been placed
where the dead code used to be, and it will be triggered if that code path is
ever taken. I have also updated comments to reflect that this code path is
(believed to be) unreachable in all versions of Derby. I haven't been able to
convince myself 100%, but I'm fairly confident that it's unreachable.
All the regression tests ran cleanly with the patch.
> Reduce visibility of classes and methods under impl/sql
> -------------------------------------------------------
>
> Key: DERBY-6169
> URL: https://issues.apache.org/jira/browse/DERBY-6169
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.11.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: derby-6169-01-a.diff, derby-6169-02-a.diff,
> derby-6169-03-a.diff, derby-6169-04-a.diff, derby-6169-05-a.diff,
> derby-6169-06-a.diff, derby-6169-06-b.diff, derby-6169-07-a.diff,
> derby-6169-08-a.diff, derby-6169-09-a.diff, derby-6169-10-a.diff
>
>
> My IDE shows many warnings in the classes under impl/sql because they are
> public and may make parts of the internal state more visible than necessary.
> I'd like to reduce the visibility of classes and methods, if possible, to
> make it clearer to IDEs and tools that perform static analysis that the code
> is only accessed from the same package, and reduce some of the noise from the
> tools.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
