[
https://issues.apache.org/jira/browse/DERBY-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-6169:
--------------------------------------
Attachment: derby-6169-13-a.diff
Attaching derby-6169-13-a.diff which cleans up the last set of "Exporting
non-public type through public API" warnings I see in the impl/sql subtree.
The patch reduces the visibility of the fields and methods to package or
private if possible. Some of them were actually not used, and those fields and
methods were removed.
Some methods had to stay public because they were interface methods. The patch
changes the signatures of these methods to use public interfaces instead of the
non-public types. Specifically, the signatures of some methods in the
RelationalOperator interface were changed to use Optimizable instead of
FromTable and ExpressionClassBuilderInterface instead of ExpressionClassBuilder.
All regression tests passed.
> Reduce visibility of classes and methods under impl/sql
> -------------------------------------------------------
>
> Key: DERBY-6169
> URL: https://issues.apache.org/jira/browse/DERBY-6169
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.11.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: derby-6169-01-a.diff, derby-6169-02-a.diff,
> derby-6169-03-a.diff, derby-6169-04-a.diff, derby-6169-05-a.diff,
> derby-6169-06-a.diff, derby-6169-06-b.diff, derby-6169-07-a.diff,
> derby-6169-08-a.diff, derby-6169-09-a.diff, derby-6169-10-a.diff,
> derby-6169-11-a.diff, derby-6169-12-a.diff, derby-6169-13-a.diff
>
>
> My IDE shows many warnings in the classes under impl/sql because they are
> public and may make parts of the internal state more visible than necessary.
> I'd like to reduce the visibility of classes and methods, if possible, to
> make it clearer to IDEs and tools that perform static analysis that the code
> is only accessed from the same package, and reduce some of the noise from the
> tools.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
