[ 
https://issues.apache.org/jira/browse/DERBY-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton updated DERBY-6291:
-----------------------------------

    Attachment: setIntPatch.txt

I ran the attached setIntPatch.txt under my debugger to see
how the new test behaves.

With this patch, we call setInt(String parameterName, int x) 4 times:

1) The first time, we call EmbedCallableStatement.setInt(String,int),
   which directly throws Util.notImplemented();

2) The second time, we call ClientCallableStatement.setInt(String,int),
   which directly throws jdbcMethodNotImplemented;

3) The third time, we call LogicalCallableStatement.setInt(String,int),
   which then calls ClientCallableStatement.setInt(String,int),
   which directly throws jdbcMethodNotImplemented;

4) The fourth time, we call BrokeredCallableStatement.setInt(String,int),
   which then calls EmbedCallableStatement.setInt(String,int),
   which directly throws Util.notImplemented();

So I definitely think that test cases like these would add
value to our test suite by (more thoroughly) testing the
as-yet-unimplemented JDBC 3.0 named parameter support.

And when we do eventually get around to implementing those
JDBC features, these test cases will be useful as a
starting point for that implementation.
                
> Improve code coverage of  org.apache.derby.iapi.jdbc.BrokeredCallableStatement
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-6291
>                 URL: https://issues.apache.org/jira/browse/DERBY-6291
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>            Reporter: ahsan shamsudeen
>            Assignee: ahsan shamsudeen
>            Priority: Minor
>              Labels: derby_triage10_11
>         Attachments: DERBY-6291.patch, setIntPatch.txt
>
>
> According to code coverage analysis, 
> org.apache.derby.iapi.jdbc.BrokeredCallableStatement is 
> exercised poorly by of our regression tests. The current coverage report for 
> this class can be found at 
> http://dbtg.foundry.sun.com/derby/test/coverage/_files/a9.html
> This task is to investigate this class, and either remove the unused code, or 
> add
> regression test that exercise the code, as appropriate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to