[
https://issues.apache.org/jira/browse/DERBY-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-534:
-------------------------------------
Attachment: derby-534-09-b-drop-column-deps.diff
There was a failure in the upgrade tests with the patch, in the test case
Changes10_7.testAlterTableDropColumnAndTriggerAction. The reason was that the
patch factored out the call that retrieved the trigger action SPS from
columnDroppedAndTriggerDependencies(), but in databases soft-upgraded from 10.6
and earlier the call had to be inside the try/catch block in
columnDroppedAndTriggerDependencies() to work around missing dependency
tracking in those versions. Since it was no longer inside the try/catch block,
an expected error came out with the wrong SQLState because it hadn't been
caught and replaced with an exception with the correct SQLState.
The derby-534-09-b-drop-column-deps.diff patch changes this back so that
getActionSPS() is called at the same place as before. Instead of passing the
SPS as an argument to the columnDroppedAndTriggerDependencies() method, the
method now needs to check how it's called and determine whether it should call
getActionSPS() or getWhenClauseSPS().
All regression tests passed with the revised patch.
> Support use of the WHEN clause in CREATE TRIGGER statements
> -----------------------------------------------------------
>
> Key: DERBY-534
> URL: https://issues.apache.org/jira/browse/DERBY-534
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Kristian Waagan
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Labels: derby_triage10_11
> Attachments: derby-534-01-a-syntax.diff,
> derby-534-02-a-refactor.diff, derby-534-03-a-npe-testcase.diff,
> derby-534-04-a-referencing.diff, derby-534-05-a-generated-cols.diff,
> derby-534-06-a-temptables.diff, derby-534-07-a-more-restrictions.diff,
> derby-534-08-a-test-invalidation.diff, derby-534-09-a-drop-column-deps.diff,
> derby-534-09-b-drop-column-deps.diff, parser.diff, WhenClause.html,
> WhenClause.html, WhenClause.html, WhenClause.html
>
>
> Support use of the WHEN clause in CREATE TRIGGER statements. The clause is
> described in the SQL standard (2003) in chapter "11.39 <trigger definition>"
> under "<triggered action>".
> There are traces in the code that suggests some work has been done on this
> earlier. If anyone knows something about this, please add a comment to this
> issue.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
