[ 
https://issues.apache.org/jira/browse/DERBY-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992545#comment-13992545
 ] 

Mamta A. Satoor commented on DERBY-6337:
----------------------------------------

Hi Myrna, thanks for reviewing the patch. 

With the new patch, chances of us running into this issue and printing the 
stack trace should be extremely unlikely. The patch waits for some time after 
receiving the reply too short exception and send a ping back to the server and 
this time we should get server down message. But in the rare case that we get 
reply too short exception again, then we will pint the stack trace.

I ran junit suite and derbyall with these changes. junit ran fine with no new 
errors. derbyall gave errors for simpleApp as shown below. But I am getting 
this error in simpleApp consistently even without my changes. I will go ahead 
and create a jira for this simpleApp failure. There is no derby.log for this 
failure probably because Derby engine was never started because of no suitable 
driver error. Not sure why the test is running into no suitable driver error 
though. I will go ahead and commit my changes for this issue. Thanks

********* Diff file derbyall/simpledemo/SimpleApp.diff
*** Start: SimpleApp jdk1.6.0 derbyall:simpledemo 2014-05-07 17:21:18 ***
2 del
< Connected to and created database derbyDB
3 del
< Created table location
4 del
< Inserted 1956 Webster
5 del
< Inserted 1910 Union
6 del
< Updated 1956 Webster to 180 Grand
7 del
< Updated 180 Grand to 300 Lakeshore
8 del
< Verified the rows
9 del
< Dropped table location
10 del
< Committed the transaction
11 del
< Derby shut down normally
11a2,5
> ----- SQLException -----
>   SQL State:  08001
>   Error Code: 0
>   Message:    No suitable driver
Test Failed.
*** End:   SimpleApp jdk1.6.0 derbyall:simpledemo 2014-05-07 17:21:19 ***


> derbynet.ServerPropertiesTest.ttestSetPortPriority prints exception  
> java.lang.Exception: DRDA_InvalidReplyTooShort.S:Invalid reply f rom network 
> server: Insufficient data. but test passes
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-6337
>                 URL: https://issues.apache.org/jira/browse/DERBY-6337
>             Project: Derby
>          Issue Type: Bug
>         Environment: Windows 7, IBM java 7 
> java version "1.7.0"
> Java(TM) SE Runtime Environment (build pwi3270sr5-20130619_01(SR5))
> IBM J9 VM (build 2.6, JRE 1.7.0 Windows 7 x86-32 20130617_152572 (JIT 
> enabled, AOT enabled)
> J9VM - R26_Java726_SR5_20130617_1436_B152572
> JIT  - r11.b04_20130528_38954ifx1
> GC   - R26_Java726_SR5_20130617_1436_B152572
> J9CL - 20130617_152572)
> JCL - 20130616_01 based on Oracle 7u25-b12
> With IBM_JAVA_OPTIONS=-Xgcpolicy:optthruput -Xjit:count=0 -Xnocompressedrefs
>            Reporter: Kathey Marsden
>         Attachments: DERBY6337_patch1_diff.txt, DERBY6337_patch1_diff.txt, 
> DERBY6337_patch2_diff.txt
>
>
> On Windows on IBM JVM with 
> IBM_JAVA_OPTIONS=-Xgcpolicy:optthruput -Xjit:count=0 -Xnocompressedrefs
> derbynet.ServerPropertiesTest prints the exception:
> (net)derbynet.ServerPropertiesTest.ttestSetPortPriority java.lang.Exception: 
> DRDA_InvalidReplyTooShort.S:Invalid reply f
> rom network server: Insufficient data.
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessageWork(Unknown
>  Source)
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessage(Unknown
>  Source)
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.fillReplyBuffer(Unknown 
> Source)
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.readResult(Unknown Source)
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.pingWithNoOpen(Unknown 
> Source)
>         at org.apache.derby.impl.drda.NetworkServerControlImpl.ping(Unknown 
> Source)
>         at org.apache.derby.drda.NetworkServerControl.ping(Unknown Source)
>         at 
> org.apache.derbyTesting.junit.NetworkServerTestSetup.pingForServerUp(NetworkServerTestSetup.java:613)
>         at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ServerPropertiesTest.canPingServer(ServerPropertiesTest.
> java:280)
>         at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ServerPropertiesTest.ttestSetPortPriority(ServerProperti
> esTest.java:476)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:76)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:607)
>         at junit.framework.TestCase.runTest(TestCase.java:164)
>         at junit.framework.TestCase.runBare(TestCase.java:130)
>         at 
> org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:117)
>         at 
> org.apache.derbyTesting.junit.BaseJDBCTestCase.runBareOverridable(BaseJDBCTestCase.java:442)
>         at 
> org.apache.derbyTesting.junit.BaseJDBCTestCase.runBare(BaseJDBCTestCase.java:459)
>         at junit.framework.TestResult$1.protect(TestResult.java:106)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.framework.TestResult.run(TestResult.java:109)
>         at junit.framework.TestCase.run(TestCase.java:120)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)
>         at 
> org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)
>         at junit.framework.TestSuite.runTest(TestSuite.java:230)
>         at junit.framework.TestSuite.run(TestSuite.java:225)
>         at junit.textui.TestRunner.doRun(TestRunner.java:121)
>         at junit.textui.TestRunner.start(TestRunner.java:185)
>         at junit.textui.TestRunner.main(TestRunner.java:143)
> java.lang.Exception: DRDA_InvalidReplyTooShort.S:Invalid reply from network 
> server: Insufficient data.
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessageWork(Unknown
>  Source)
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessage(Unknown
>  Source)
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.fillReplyBuffer(Unknown 
> Source)
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.readResult(Unknown Source)
>         at 
> org.apache.derby.impl.drda.NetworkServerControlImpl.pingWithNoOpen(Unknown 
> Source)
>         at org.apache.derby.impl.drda.NetworkServerControlImpl.ping(Unknown 
> Source)
>         at org.apache.derby.drda.NetworkServerControl.ping(Unknown Source)
>         at 
> org.apache.derbyTesting.junit.NetworkServerTestSetup.pingForServerUp(NetworkServerTestSetup.java:613)
>         at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ServerPropertiesTest.canPingServer(ServerPropertiesTest.
> java:280)
>         at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ServerPropertiesTest.shutdownServer(ServerPropertiesTest
> .java:309)
>         at 
> org.apache.derbyTesting.functionTests.tests.derbynet.ServerPropertiesTest.ttestSetPortPriority(ServerProperti
> esTest.java:483)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:76)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:607)
>         at junit.framework.TestCase.runTest(TestCase.java:164)
>         at junit.framework.TestCase.runBare(TestCase.java:130)
>         at 
> org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:117)
>         at 
> org.apache.derbyTesting.junit.BaseJDBCTestCase.runBareOverridable(BaseJDBCTestCase.java:442)
>         at 
> org.apache.derbyTesting.junit.BaseJDBCTestCase.runBare(BaseJDBCTestCase.java:459)
>         at junit.framework.TestResult$1.protect(TestResult.java:106)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.framework.TestResult.run(TestResult.java:109)
>         at junit.framework.TestCase.run(TestCase.java:120)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)
>         at 
> org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)
>         at junit.framework.TestSuite.runTest(TestSuite.java:230)
>         at junit.framework.TestSuite.run(TestSuite.java:225)
>         at junit.textui.TestRunner.doRun(TestRunner.java:121)
>         at junit.textui.TestRunner.start(TestRunner.java:185)
>         at junit.textui.TestRunner.main(TestRunner.java:143)
> used 53367 ms .
> (net)derbynet.ServerPropertiesTest.ttestDefaultProperties used 387 ms .
> (net)derbynet.ServerPropertiesTest.testToggleTrace used 34428 ms .
> (net)derbynet.ServerPropertiesTest.testToggleLogConnections used 34064 ms
> Time: 157.034
> OK (4 tests)
> but the test passes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to