[ 
https://issues.apache.org/jira/browse/DERBY-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249920#comment-14249920
 ] 

Kim Haase commented on DERBY-3195:
----------------------------------

These are excellent doc changes, Myrna. It is good to link to the Java SE 
information. Thanks for picking this up.

These are just nits: there should be a "the" in front of "Network Server" in a 
couple of places, and the policy file names should be surrounded by tags to put 
them in code font. Also, in the second topic, the phrase "when started" doesn't 
make it clear exactly what is being started (there are 3 nouns it might apply 
to), so you might want to reword those sentences to be exactly the same as the 
ones in the first topic.


src/adminguide/tadmincbdjhhfd.dita:

... By default, a security manager
will be installed with a default security policy when the Network Server is 
started. This 
default policy file is called <codeph>server.policy</codeph> and is part of 
<codeph>derbynet.jar</codeph>.
There is also a <codeph>template.policy</codeph> file ...


src/adminguide/cadminov825266.dita:

By default, a security manager
will be installed with a default security policy when the Network Server is 
started. This 
default policy file is called <codeph>server.policy</codeph> and is part of 
<codeph>derbynet.jar</codeph>.


java/drda/org/apache/derby/drda/NetworkServerControl.java:

In the first changed lines, it should again be "the Network Server" (I realize 
this error was there before).

The additional line for "Start a Network Server" needs an "a":

"with a default security policy."

BTW, in the very first line of this Javadoc file, the word "retrieve" is 
misspelled -- feel like fixing it? I will understand if not.

> Describe if default security manager & policy is installed or not on each of 
> the mechanisms to start the network server.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3195
>                 URL: https://issues.apache.org/jira/browse/DERBY-3195
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation, Javadoc
>    Affects Versions: 10.3.1.4
>            Reporter: Daniel John Debrunner
>            Assignee: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-3195.diff, DERBY-3195_doc.diff, 
> NetworkServerControl.html, cadminov825266.html, tadmincbdjhhfd.html
>
>
> The explicit mechanisms to start the network server make no mention of if 
> they install a default security manager and policy or not.
> These are at least:
> NetworkServerControl javadoc
>    summary - start command on command line
>    main() method
>    start() method
> derby.drda.startNetworkServerProperty
> Each start mechanism should clearly state if they install or do not install 
> the default security manager and policy.
> (Other starts commands are)
> java -jar derbynet.jar
> java -jar derbyrun.jar server start
> I didn't look to see if these document the default policy or not, not sure 
> where they are documented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to