[
https://issues.apache.org/jira/browse/DERBY-6828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144688#comment-15144688
]
Knut Anders Hatlen commented on DERBY-6828:
-------------------------------------------
Hi Bryan,
Your patch fixes the immediate problem. Before your patch:
{noformat}
$ java -Duser.language=cs -Dderby.drda.debug=true -jar
/code/derby/trunk/jars/sane/derbynet.jar start
Fri Feb 12 16:03:52 CET 2016 : null
java.lang.NullPointerException
at
org.apache.derby.iapi.tools.i18n.LocalizedResource.getTextMessage(LocalizedResource.java:293)
at
org.apache.derby.impl.drda.NetworkServerControlImpl.localizeMessage(NetworkServerControlImpl.java:3625)
at
org.apache.derby.impl.drda.NetworkServerControlImpl.localizeMessage(NetworkServerControlImpl.java:3597)
at
org.apache.derby.drda.NetworkServerControl.installSecurityManager(NetworkServerControl.java:706)
at
org.apache.derby.drda.NetworkServerControl.main(NetworkServerControl.java:344)
{noformat}
After your patch:
{noformat}
$ java -Duser.language=cs -Dderby.drda.debug=true -jar
/code/derby/trunk/jars/sane/derbynet.jar start
Fri Feb 12 16:04:39 CET 2016 : DRDA_SecurityInstalled.I
total memory: 502792192 free: 495416760 Fri Feb 12 16:04:39 CET 2016
total memory: 502792192 free: 494413880 Fri Feb 12 16:04:39 CET 2016
Fri Feb 12 16:04:39 CET 2016 : Síťový server Apache Derby - 10.13.0.0 alpha -
(Unversioned directory): spuštěn a připraven přijímat připojení na portu 1527 v
{3}
{noformat}
I think there are more problems, though:
# Why did the server crash silently if the derby.drda.debug flag wasn't set? I
think it should have printed the NPE in that case too.
# When a localized message is not available, shouldn't it have printed the
English message, rather than the key?
> Network Server don't start in czech localized enviroment due missing key
> DRDA_MissingNetworkJar.S
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-6828
> URL: https://issues.apache.org/jira/browse/DERBY-6828
> Project: Derby
> Issue Type: Bug
> Components: Localization, Network Server
> Affects Versions: 10.11.1.1
> Environment: Windows 7 Profesional SP1 64bit (localized CS),
> java version "1.8.0_51"
> Java(TM) SE Runtime Environment (build 1.8.0_51-b16)
> Java HotSpot(TM) 64-Bit Server VM (build 25.51-b03, mixed mode)
> Reporter: David Ježek
> Priority: Minor
> Labels: easyfix
> Attachments: nullGuard.diff
>
>
> Network Server don't start in czech localized enviroment due missing key
> DRDA_MissingNetworkJar.S in file
> org/apache/derby/loc/drda/messages_cs.properties
> Exception:
> Thu Jul 23 15:56:24 CEST 2015 : null
> java.lang.NullPointerException
> at
> org.apache.derby.iapi.tools.i18n.LocalizedResource.getTextMessage(Unknown
> Source)
> at
> org.apache.derby.impl.drda.NetworkServerControlImpl.localizeMessage(Unknown
> Source)
> at
> org.apache.derby.impl.drda.NetworkServerControlImpl.localizeMessage(Unknown
> Source)
> at
> org.apache.derby.drda.NetworkServerControl.installSecurityManager(Unknown
> Source)
> at org.apache.derby.drda.NetworkServerControl.main(Unknown Source)
> Missing key is called in file org.apache.derby.drda.NetworkServerControl.java
> at line 818.
> Reproduce under windows in console run:
> set DERBY_OPTS=-Duser.language=cs
> startNetworkServer.bat
> Workaround:
> Run derby server under en localization.
> Windows consola run:
> set DERBY_OPTS=-Duser.language=en
> startNetworkServer.bat
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
