[ 
https://issues.apache.org/jira/browse/DERBY-6894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369157#comment-15369157
 ] 

Bryan Pendleton commented on DERBY-6894:
----------------------------------------

A couple other small comments; I didn't want them to get lost in the larger 
comment above:

1) Can you expand a little bit on this line from the patch:
{code}
+                                       vtiColumnNames.add(vtiColumnPrefix + 
""+cIndex);
{code}
I didn't understand why the string-of-length-0 needed to be part of that 
expression.

2) Adding new error messages is, happily, not too hard. But I don't know that 
we've
ever written up internal documentation on how to do it. I tried writing that 
docs and
put it in the Derby wiki here: 
https://wiki.apache.org/db-derby/AddAnErrorMessage

Perhaps you could have a look at that documentation, and give a try at adding
the new error messages when you have the time? Also, if the documentation is
not clear, please let me know so we can improve it.

> Enhance COLUMNINDEXES parsing for SYSCS_IMPORT_DATA_BULK to recognize columns 
> by name
> -------------------------------------------------------------------------------------
>
>                 Key: DERBY-6894
>                 URL: https://issues.apache.org/jira/browse/DERBY-6894
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Bryan Pendleton
>            Assignee: Danoja Dias
>            Priority: Minor
>         Attachments: Derby-6894.diff, NewDerby6894.diff, noHeaderLines.csv, 
> petlist.csv, repro.java, repro.java
>
>
> To ease maintainability and legibility of client programs, it would be
> nice if callers of SYSCS_IMPORT_DATA_BULK (and possibly also
> SYSCS_IMPORT_DATA) could refer to columns in the COLUMNINDEXES
> argument by column *NAME*, as well as by index *NUMBER*.
> So, for example, a valid COLUMNINDEXES specification might be:
>     '1,3,LastName,FirstName,7'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to