[
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333288#comment-16333288
]
Rick Hillegas edited comment on DERBY-6945 at 1/20/18 6:47 PM:
---------------------------------------------------------------
Attaching derby-6945-13-aa-create-ClientAutoloadedDriver.diff. This patch moves
the guts of ClientDriver into a new ClientAutoloadedDriver class inside the
client package space. ClientAutoloadedDriver is now the client-side driver
which is autoloaded when application code calls DriverManager.getConnection();
This eliminates several references from client code up into the troublesome
org.apache.derby.jdbc package.
I will run tests.
Touches the following files:
{noformat}
---------------------------------------------
M
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbyclient.jar.lastcontents
M
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbyclient.jar.lastcontents
A java/client/org/apache/derby/client/ClientAutoloadedDriver.java
M java/client/org/apache/derby/jdbc/ClientDriver.java
Move the guts of the client driver into ClientAutoloadedDriver.
---------------------------------------------
M build.xml
Make ClientAutoloadeDriver the client jar's autoloaded driver.
---------------------------------------------
M java/client/org/apache/derby/client/BasicClientDataSource.java
M java/client/org/apache/derby/client/ClientPooledConnection.java
M java/client/org/apache/derby/client/am/Agent.java
M java/client/org/apache/derby/client/am/ClientPreparedStatement.java
M java/client/org/apache/derby/client/am/Configuration.java
M java/client/org/apache/derby/client/am/StatementCacheInteractor.java
M java/client/org/apache/derby/client/net/NetCallableStatement.java
M java/client/org/apache/derby/client/net/NetConnection.java
M java/client/org/apache/derby/client/net/NetPreparedStatement.java
M java/client/org/apache/derby/client/net/NetStatement.java
M java/client/org/apache/derby/client/net/NetStatementReply.java
M java/client/org/apache/derby/client/net/NetXAConnection.java
M java/engine/org/apache/derby/impl/services/reflect/JarLoader.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/Wrapper41Driver.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/AutoloadTest.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DriverTest.java
Adjust imports and references accordingly.
{noformat}
was (Author: rhillegas):
Attaching derby-6945-13-aa-create-ClientAutoloadedDriver.diff. This patch moves
the guts of ClientDriver into a new ClientAutoloadedDriver class inside the
client package space. ClientAutoloadedDriver is now the client-side driver
which is autoloaded when application code calls DriverManager.getConnection();
This eliminates several references from client code up into the troublesome
org.apache.derby.jdbc package.
I will run tests.xs
Touches the following files:
{noformat}
---------------------------------------------
M
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbyclient.jar.lastcontents
M
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbyclient.jar.lastcontents
A java/client/org/apache/derby/client/ClientAutoloadedDriver.java
M java/client/org/apache/derby/jdbc/ClientDriver.java
Move the guts of the client driver into ClientAutoloadedDriver.
---------------------------------------------
M build.xml
Make ClientAutoloadeDriver the client jar's autoloaded driver.
---------------------------------------------
M java/client/org/apache/derby/client/BasicClientDataSource.java
M java/client/org/apache/derby/client/ClientPooledConnection.java
M java/client/org/apache/derby/client/am/Agent.java
M java/client/org/apache/derby/client/am/ClientPreparedStatement.java
M java/client/org/apache/derby/client/am/Configuration.java
M java/client/org/apache/derby/client/am/StatementCacheInteractor.java
M java/client/org/apache/derby/client/net/NetCallableStatement.java
M java/client/org/apache/derby/client/net/NetConnection.java
M java/client/org/apache/derby/client/net/NetPreparedStatement.java
M java/client/org/apache/derby/client/net/NetStatement.java
M java/client/org/apache/derby/client/net/NetStatementReply.java
M java/client/org/apache/derby/client/net/NetXAConnection.java
M java/engine/org/apache/derby/impl/services/reflect/JarLoader.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/Wrapper41Driver.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/AutoloadTest.java
M
java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DriverTest.java
Adjust imports and references accordingly.
{noformat}
> Re-package Derby as a collection of jigsaw modules
> --------------------------------------------------
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.13.1.2
> Reporter: Rick Hillegas
> Priority: Major
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff,
> derby-6945-02-ab-newDerbySharedJar.diff,
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff,
> derby-6945-04-aa-moveRunClass.diff,
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff,
> derby-6945-06-aa-removeOtherSharedDuplicates.diff,
> derby-6945-07-aa-net_client_overlap.diff,
> derby-6945-08-aa-move_shared_iapi_under_shared.diff,
> derby-6945-08-ab-move_shared_iapi_under_shared.diff,
> derby-6945-08-ad-move_shared_iapi_under_shared.diff,
> derby-6945-09-ab-moveInternalDriver.diff, derby-6945-10-aa-moveDriver42.diff,
> derby-6945-11-ab-moveAutoloadedDriver.diff,
> derby-6945-12-ab-moveClientDataSourceInterface.diff,
> derby-6945-13-aa-create-ClientAutoloadedDriver.diff, jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider
> re-packaging Derby as a set of jigsaw modules. This would result in a
> different set of release artifacts. This might be a good opportunity to
> address the Tomcat artifactory issues raised by issue DERBY-6944.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
