[
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507413#comment-16507413
]
Rick Hillegas edited comment on DERBY-6945 at 6/10/18 2:53 PM:
---------------------------------------------------------------
Attaching derby-6945-38-aa-javadocCleanup.diff. This patch cleans up perhaps a
thousand javadoc warnings. Tests passed cleanly for me on this patch.
After renaming the source roots, I was able to make some progress toward
generating module-aware javadoc. However, my javadoc commands wander into some
different branch of the javadoc pinball machine, which discloses thousands of
previously undetected javadoc warnings. These warnings include missing @param,
@return, and @throws declarations as well as badly formatted or obsolete html.
I am cleaning out this augean stable now.
Once I have cleaned up as many of these warnings as I can find, I will pose
more questions on the javadoc mailing list. I expect that I will have to make
another pass through javadoc warnings after that.
Touches the following files:
{noformat}
M
java/org.apache.derby.client/org/apache/derby/client/BasicClientDataSource.java
M
java/org.apache.derby.client/org/apache/derby/client/ClientAutoloadedDriver.java
M
java/org.apache.derby.client/org/apache/derby/client/ClientDataSourceInterface.java
M java/org.apache.derby.client/org/apache/derby/client/am/ClientBlob.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientCallableStatement.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientCallableStatement42.java
M java/org.apache.derby.client/org/apache/derby/client/am/ClientClob.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientConnection.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientDatabaseMetaData.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientJDBCObjectFactory.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientMessageId.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientPreparedStatement.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientPreparedStatement42.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientResultSet.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientStatement.java
M
java/org.apache.derby.client/org/apache/derby/client/am/Configuration.java
M java/org.apache.derby.client/org/apache/derby/client/am/Cursor.java
M java/org.apache.derby.client/org/apache/derby/client/am/DateTime.java
M
java/org.apache.derby.client/org/apache/derby/client/am/DateTimeValue.java
M java/org.apache.derby.client/org/apache/derby/client/am/Decimal.java
M
java/org.apache.derby.client/org/apache/derby/client/am/EncryptionManager.java
M
java/org.apache.derby.client/org/apache/derby/client/am/FailedProperties40.java
M java/org.apache.derby.client/org/apache/derby/client/am/Lob.java
M
java/org.apache.derby.client/org/apache/derby/client/am/LogicalConnection.java
M
java/org.apache.derby.client/org/apache/derby/client/am/SQLExceptionFactory.java
M java/org.apache.derby.client/org/apache/derby/client/am/Section.java
M
java/org.apache.derby.client/org/apache/derby/client/am/SignedBinary.java
M
java/org.apache.derby.client/org/apache/derby/client/am/SqlException.java
M java/org.apache.derby.client/org/apache/derby/client/am/SqlWarning.java
M java/org.apache.derby.client/org/apache/derby/client/am/Sqlca.java
M java/org.apache.derby.client/org/apache/derby/client/am/Utils.java
M java/org.apache.derby.client/org/apache/derby/client/am/Utils42.java
M
java/org.apache.derby.client/org/apache/derby/client/net/ClientJDBCObjectFactoryImpl.java
M
java/org.apache.derby.client/org/apache/derby/client/net/NetXAConnection.java
M
java/org.apache.derby.client/org/apache/derby/client/net/NetXAResource.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/drda/NaiveTrustManager.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/ErrorStringBuilder.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/MessageUtils.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/PublicAPI.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/StandardException.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/i18n/BundleFinder.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/i18n/LocaleFinder.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/i18n/MessageService.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/i18n/MessageUtil.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/info/JVMInfo.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/info/ProductVersionHolder.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/reference/Attribute.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/reference/Property.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/reference/SQLState.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/sanity/SanityManager.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/stream/HeaderPrintWriter.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/stream/InfoStreams.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/util/ArrayUtil.java
M
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/LuceneIndexDescriptor.java
M
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/LuceneUtils.java
M
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/SimpleJsonUtils.java
M
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/SimpleJsonVTI.java
M
java/org.apache.derby.server/org/apache/derby/drda/NetworkServerControl.java
M
java/org.apache.derby.server/org/apache/derby/impl/drda/NetworkServerControlImpl.java
M
java/org.apache.derby.server/org/apache/derby/impl/drda/ProtocolTestAdapter.java
M java/org.apache.derby.server/org/apache/derby/impl/drda/package.html
{noformat}
was (Author: rhillegas):
Attaching derby-6945-38-aa-javadocCleanup.diff. This patch cleans up perhaps a
thousand javadoc warnings. Tests passed cleanly for me on this patch.
After renaming the source roots, I was able to make some progress toward
generating module-aware javadoc. However, my javadoc commands wander into some
different branch of the javadoc pinball machine, which discloses thousands of
previously undetected javadoc warnings. These warnings include missing @param,
@return, and @throw declarations as well as badly formatted or obsolete html. I
am cleaning out this augean stable now.
Once I have cleaned up as many of these warnings as I can find, I will pose
more questions on the javadoc mailing list. I expect that I will have to make
another pass through javadoc warnings after that.
Touches the following files:
{noformat}
M
java/org.apache.derby.client/org/apache/derby/client/BasicClientDataSource.java
M
java/org.apache.derby.client/org/apache/derby/client/ClientAutoloadedDriver.java
M
java/org.apache.derby.client/org/apache/derby/client/ClientDataSourceInterface.java
M java/org.apache.derby.client/org/apache/derby/client/am/ClientBlob.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientCallableStatement.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientCallableStatement42.java
M java/org.apache.derby.client/org/apache/derby/client/am/ClientClob.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientConnection.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientDatabaseMetaData.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientJDBCObjectFactory.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientMessageId.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientPreparedStatement.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientPreparedStatement42.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientResultSet.java
M
java/org.apache.derby.client/org/apache/derby/client/am/ClientStatement.java
M
java/org.apache.derby.client/org/apache/derby/client/am/Configuration.java
M java/org.apache.derby.client/org/apache/derby/client/am/Cursor.java
M java/org.apache.derby.client/org/apache/derby/client/am/DateTime.java
M
java/org.apache.derby.client/org/apache/derby/client/am/DateTimeValue.java
M java/org.apache.derby.client/org/apache/derby/client/am/Decimal.java
M
java/org.apache.derby.client/org/apache/derby/client/am/EncryptionManager.java
M
java/org.apache.derby.client/org/apache/derby/client/am/FailedProperties40.java
M java/org.apache.derby.client/org/apache/derby/client/am/Lob.java
M
java/org.apache.derby.client/org/apache/derby/client/am/LogicalConnection.java
M
java/org.apache.derby.client/org/apache/derby/client/am/SQLExceptionFactory.java
M java/org.apache.derby.client/org/apache/derby/client/am/Section.java
M
java/org.apache.derby.client/org/apache/derby/client/am/SignedBinary.java
M
java/org.apache.derby.client/org/apache/derby/client/am/SqlException.java
M java/org.apache.derby.client/org/apache/derby/client/am/SqlWarning.java
M java/org.apache.derby.client/org/apache/derby/client/am/Sqlca.java
M java/org.apache.derby.client/org/apache/derby/client/am/Utils.java
M java/org.apache.derby.client/org/apache/derby/client/am/Utils42.java
M
java/org.apache.derby.client/org/apache/derby/client/net/ClientJDBCObjectFactoryImpl.java
M
java/org.apache.derby.client/org/apache/derby/client/net/NetXAConnection.java
M
java/org.apache.derby.client/org/apache/derby/client/net/NetXAResource.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/drda/NaiveTrustManager.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/ErrorStringBuilder.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/MessageUtils.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/PublicAPI.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/error/StandardException.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/i18n/BundleFinder.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/i18n/LocaleFinder.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/i18n/MessageService.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/i18n/MessageUtil.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/info/JVMInfo.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/info/ProductVersionHolder.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/reference/Attribute.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/reference/Property.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/reference/SQLState.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/sanity/SanityManager.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/stream/HeaderPrintWriter.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/stream/InfoStreams.java
M
java/org.apache.derby.commons/org/apache/derby/shared/common/util/ArrayUtil.java
M
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/LuceneIndexDescriptor.java
M
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/LuceneUtils.java
M
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/SimpleJsonUtils.java
M
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/SimpleJsonVTI.java
M
java/org.apache.derby.server/org/apache/derby/drda/NetworkServerControl.java
M
java/org.apache.derby.server/org/apache/derby/impl/drda/NetworkServerControlImpl.java
M
java/org.apache.derby.server/org/apache/derby/impl/drda/ProtocolTestAdapter.java
M java/org.apache.derby.server/org/apache/derby/impl/drda/package.html
{noformat}
> Re-package Derby as a collection of jigsaw modules
> --------------------------------------------------
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
> Issue Type: Improvement
> Affects Versions: 10.13.1.2
> Reporter: Rick Hillegas
> Priority: Major
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff,
> derby-6945-02-ab-newDerbySharedJar.diff,
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff,
> derby-6945-04-aa-moveRunClass.diff,
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff,
> derby-6945-06-aa-removeOtherSharedDuplicates.diff,
> derby-6945-07-aa-net_client_overlap.diff,
> derby-6945-08-aa-move_shared_iapi_under_shared.diff,
> derby-6945-08-ab-move_shared_iapi_under_shared.diff,
> derby-6945-08-ad-move_shared_iapi_under_shared.diff,
> derby-6945-09-ab-moveInternalDriver.diff, derby-6945-10-aa-moveDriver42.diff,
> derby-6945-11-ab-moveAutoloadedDriver.diff,
> derby-6945-12-ab-moveClientDataSourceInterface.diff,
> derby-6945-13-aa-create-ClientAutoloadedDriver.diff,
> derby-6945-14-aa-moveMoreEmbeddedClassesOutOfPublicAPI.diff,
> derby-6945-15-aa-moveMoreClientClassesOutOfPublicAPI.diff,
> derby-6945-16-aa-consolidatePublicAPI.diff,
> derby-6945-17-aa-resealPackagesIn-derbyshared.diff,
> derby-6945-18-aa-resealLocalizationPackage.diff,
> derby-6945-19-ad-movePublicAPIintoToolsJar.diff,
> derby-6945-20-aa-removeClasslister.diff,
> derby-6945-21-aa-simplifyBuildScripts.diff,
> derby-6945-21-ab-simplifyBuildScripts.diff,
> derby-6945-22-ad-isolateClassesByArtifact.diff,
> derby-6945-22-ae-isolateClassesByArtifact.diff,
> derby-6945-22-af-isolateClassesByArtifact.diff,
> derby-6945-23-aa-upgradeToAnt_1.10.2.diff,
> derby-6945-24-aa-fixNativeAuthenticationServiceTest.diff,
> derby-6945-25-ab-moduleDescriptors.diff,
> derby-6945-26-aa-packagePrivateTests.diff,
> derby-6945-27-aa-adjustModulesForTests.diff,
> derby-6945-28-aa-testingModuleDescriptor.diff,
> derby-6945-29-aa-disable-SimpleApp-test.diff,
> derby-6945-30-ab-move-clientmessages-toolsmessages.diff,
> derby-6945-31-aa-clientmessages-ResourceBundleProvider.diff,
> derby-6945-32-aa-messageLookupCleanup.diff,
> derby-6945-33-ab-moveLocalizations.diff,
> derby-6945-34-aa-licenseHeaders.diff,
> derby-6945-35-aa-removeSpuriousCharacter.diff,
> derby-6945-36-aa-moduleDescriptorsForLocaleJars.diff,
> derby-6945-38-aa-javadocCleanup.diff, derby-6945-XX-moveDataSourceFactories,
> jdeps.out.tar, weirdAnt.out
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider
> re-packaging Derby as a set of jigsaw modules. This would result in a
> different set of release artifacts. This might be a good opportunity to
> address the Tomcat artifactory issues raised by issue DERBY-6944.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
