[
https://issues.apache.org/jira/browse/DERBY-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098537#comment-17098537
]
Richard N. Hillegas commented on DERBY-7076:
--------------------------------------------
Thanks for that extra detail about the benefits provided by this patch. At this
time, I do not see any evidence that the patch will provide a measurable
improvement to Derby's behavior.
The patch does compile cleanly under Java 11, but not under Java 9. The problem
is that the java.nio.file.Path.of() method was introduced by Java 11 and does
not appear in the Java 9 libraries. As a consequence, this code would fail on
Java 9 JVMs. The platform policy for the 10.15 family is to run on all
platforms from Java 9 on up.
As a practical matter, I think that most people migrating off Java 8 would skip
over intervening non-LTS versions and upgrade to Java 11 directly. I would
support a community vote to move the base platform version forward to Java 11
for the 10.16 release family.
> replace old "new FileInputStreamReader()" from java.io to the java.nio
> Files.newInputStream
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-7076
> URL: https://issues.apache.org/jira/browse/DERBY-7076
> Project: Derby
> Issue Type: Task
> Reporter: Yasser Mustafa Bazzi Bordonal
> Priority: Minor
> Attachments: nio.diff
>
>
> This should avoid some allocations done by the old java.io and not disrupt
> any major part of derby, since im a new contributor i would like feedback to
> see if this breaks anything since im not able to run the tests on my computer
> but it builds and works just fine.
> Thanks in advance.
> [^nio.diff]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
