[ 
https://issues.apache.org/jira/browse/DERBY-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098546#comment-17098546
 ] 

Yasser Mustafa Bazzi Bordonal commented on DERBY-7076:
------------------------------------------------------

Oh sorry about that, i didn't see that Path.of was introduced in java 11, i 
could substitute the code with Paths.get() method and if the community vote to 
upgrade to java 11 and then use the Path.of().

As of the benefits i don't think that there are many benefits and is more of a 
cleanup of old methods, even if this change isn't accepted i would also like to 
do some cleanup on some unused imports on the code and with time make other 
changes that should not affect the behavior of the program.

> replace old "new FileInputStreamReader()" from java.io to the java.nio 
> Files.newInputStream
> -------------------------------------------------------------------------------------------
>
>                 Key: DERBY-7076
>                 URL: https://issues.apache.org/jira/browse/DERBY-7076
>             Project: Derby
>          Issue Type: Task
>            Reporter: Yasser Mustafa Bazzi Bordonal
>            Priority: Minor
>         Attachments: nio.diff
>
>
> This should avoid some allocations done by the old java.io and not disrupt 
> any major part of derby, since im a new contributor i would like feedback to 
> see if this breaks anything since im not able to run the tests on my computer 
> but it builds and works just fine.
> Thanks in advance.
> [^nio.diff]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to