[ 
https://issues.apache.org/jira/browse/DERBY-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647734#comment-17647734
 ] 

Richard N. Hillegas commented on DERBY-7149:
--------------------------------------------

Attaching derby-7149-01-aa-deprecateURLconstructor.diff. This patch attempts to 
fix code and javadoc warnings introduced by Open JDK build 20-ea+27-2213. 
Unfortunately, many tests fail. One of the issues which the patch addresses is 
the deprecation of URL constructors by 
https://bugs.openjdk.org/browse/JDK-8294241. My naive attempt to work around 
this was to replace

{noformat}
new URL(urlString)
{noformat}

with

{noformat}
(new URI(urlString)).toURL();
{noformat}

Here is the error I see when I run the old harness RecoveryAfterBackup test:

java.lang.IllegalArgumentException: URI is not absolute
        at java.base/java.net.URL.of(URL.java:854)
        at java.base/java.net.URI.toURL(URI.java:1144)
        at org.apache.derby.impl.store.raw.RawStore.backup(RawStore.java:641)

I will ask the Java team for advice about how to workaround this deprecation in 
applications which rely on relative URIs.

Touches the following files:

{noformat}
M       java/build/org/apache/derbyBuild/JiraConnector.java
M       java/build/org/apache/derbyBuild/ReleaseNotesGenerator.java
M       
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbyTesting.jar.lastcontents
M       
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbyTesting.jar.lastcontents
M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/InternalDriver.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/security/SecurityUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/context/ContextManager.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/context/SystemContext.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/FileUtil.java
M       java/org.apache.derby.engine/org/apache/derby/impl/io/URLFile.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/jdbc/InternalClob.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/jdbc/LOBStoredProcedure.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/load/ImportReadData.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/services/monitor/BaseMonitor.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/compile/GroupByNode.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/compile/UpdateNode.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/execute/GroupedAggregateResultSet.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/execute/JarUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/execute/RowTriggerExecutor.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/store/raw/RawStore.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/store/raw/log/LogToFile.java
M       java/org.apache.derby.engine/org/apache/derby/vti/XmlVTI.java
M       
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/SimpleJsonUtils.java
A       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/harness/jdk120.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbc4/Derby3650Test.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbc4/ResultSetTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/BLOBDataModelSetup.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/BlobClob4BlobTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/BlobStoredProcedureTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/CallableTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/ClobStoredProcedureTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/DataSourceReferenceTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/StatementPoolingTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/management/JDBCMBeanTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/management/NetworkServerMBeanTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/management/VersionMBeanTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/store/BaseTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/store/OnlineCompressTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/store/StreamingColumnTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/store/dropcrash.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/upgradeTests/UpgradeClassLoader.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/unitTests/harness/BasicUnitTestManager.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/unitTests/harness/T_MultiThreadedIterations.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/unitTests/junit/ReaderToUTF8StreamTest.java
M       java/org.apache.derby.tools/org/apache/derby/impl/tools/ij/mtTester.java
M       
java/org.apache.derby.tools/org/apache/derby/impl/tools/sysinfo/Main.java
{noformat}



> Make it possible to build and test Derby cleanly with JDK 20
> ------------------------------------------------------------
>
>                 Key: DERBY-7149
>                 URL: https://issues.apache.org/jira/browse/DERBY-7149
>             Project: Derby
>          Issue Type: Task
>          Components: Build tools
>    Affects Versions: 10.17.0.0
>            Reporter: Richard N. Hillegas
>            Assignee: Richard N. Hillegas
>            Priority: Major
>         Attachments: derby-7149-01-aa-deprecateURLconstructor.diff
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to