[ 
https://issues.apache.org/jira/browse/DERBY-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650044#comment-17650044
 ] 

Richard N. Hillegas commented on DERBY-7149:
--------------------------------------------

Attaching derby-7149-01-ac-deprecateURLconstructor.diff. This patch addresses 
the following issues encountered when building and testing with Open JDK build 
20-ea+27-2213:

1) The deprecation of public URL constructors (JDK-8294241).

2) New javadoc warnings.

I fixed the URL-related test problems in the previous patch by adding catch 
blocks for IllegalArgumentException. Oddly enough, the 0-arg method URI.toURL() 
raises that exception.

I backed out changes related to the deprecation (with intent to remove) of the 
java.lang.ThreadDeath class. That, in turn, relates to the deprecation (with 
intent to remove) of the Thread.stop() method. I need to ask the experts about 
how we should handle the disappearance of Thread.stop().

Tests passed cleanly with this patch with both the classpath and the module 
path except for the problems seen in CacheManagerMBeanTest.

Touches the following files:

{noformat}
M       
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbyTesting.jar.lastcontents
M       
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbyTesting.jar.lastcontents
A       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/harness/jdk120.java

Added a new JVM testing type to represent JDK 20.


M       java/build/org/apache/derbyBuild/JiraConnector.java
M       java/build/org/apache/derbyBuild/ReleaseNotesGenerator.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/services/io/FileUtil.java
M       java/org.apache.derby.engine/org/apache/derby/impl/io/URLFile.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/load/ImportReadData.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/execute/JarUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/store/raw/RawStore.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/store/raw/log/LogToFile.java
M       java/org.apache.derby.engine/org/apache/derby/vti/XmlVTI.java
M       
java/org.apache.derby.optionaltools/org/apache/derby/optional/api/SimpleJsonUtils.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/CallableTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/upgradeTests/UpgradeClassLoader.java
M       
java/org.apache.derby.tools/org/apache/derby/impl/tools/sysinfo/Main.java

Changes for (1).


M       
java/org.apache.derby.engine/org/apache/derby/iapi/jdbc/InternalDriver.java
M       
java/org.apache.derby.engine/org/apache/derby/iapi/security/SecurityUtil.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/jdbc/InternalClob.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/jdbc/LOBStoredProcedure.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/compile/GroupByNode.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/compile/UpdateNode.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/execute/GroupedAggregateResultSet.java
M       
java/org.apache.derby.engine/org/apache/derby/impl/sql/execute/RowTriggerExecutor.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbc4/Derby3650Test.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbc4/ResultSetTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/BLOBDataModelSetup.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/BlobClob4BlobTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/BlobStoredProcedureTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/ClobStoredProcedureTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/DataSourceReferenceTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/jdbcapi/StatementPoolingTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/management/JDBCMBeanTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/managemen/NetworkServerMBeanTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/management/VersionMBeanTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/store/BaseTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/store/OnlineCompressTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/store/StreamingColumnTest.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/functionTests/tests/store/dropcrash.java
M       
java/org.apache.derby.tests/org/apache/derbyTesting/unitTests/junit/ReaderToUTF8StreamTest.java

Changes for (2).
{noformat}


> Make it possible to build and test Derby cleanly with JDK 20
> ------------------------------------------------------------
>
>                 Key: DERBY-7149
>                 URL: https://issues.apache.org/jira/browse/DERBY-7149
>             Project: Derby
>          Issue Type: Task
>          Components: Build tools
>    Affects Versions: 10.17.0.0
>            Reporter: Richard N. Hillegas
>            Assignee: Richard N. Hillegas
>            Priority: Major
>         Attachments: derby-7149-01-aa-deprecateURLconstructor.diff, 
> derby-7149-01-ac-deprecateURLconstructor.diff
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to