>>>>> "KAH" == Knut Anders Hatlen <[EMAIL PROTECTED]> writes:
KAH> "Dyre Tjeldvoll (JIRA)" <[email protected]> writes:
>> [ http://issues.apache.org/jira/browse/DERBY-815?page=all ]
>>
>> Dyre Tjeldvoll updated DERBY-815:
>> ---------------------------------
>>
>> Attachment: derby-815.stat
>> derby-815.diff
>> derbyall_report.txt
>>
>> Ran derbyall with the usual failures. I'll let the committers decide
>> if it is ok to check in...
KAH> Hi Dyre,
KAH> Your patch definitely looks like an improvement. A couple of comments
KAH> of cosmetic nature, though...
KAH> 1) The files you have modified use tabs for indentation more or less
KAH> consistenly, but you have used spaces. I think it's ok, but it
KAH> makes the patch harder to read.
Eh, what's your point? Do you want tabs or spaces? I'm not religious
about it, I just thought people preferred spaces...
KAH> 2) CliParam's constructor and getCliParam() could use some line
KAH> feeds.
Beauty is in the eyes of the beholder :)
KAH> 3) In parseSQLDTA_work(), some of the changes are just reformatting,
KAH> as far as I can tell:
It isn't reformatting, it is the same formatting with tab=4 space.
This is what happens when you hit the tab-key when standing on a line
that you haven't edited... but I could always try to fix it.
KAH> reader.markCollection();
KAH> - codePoint = reader.getCodePoint();
KAH> + int codePoint = reader.getCodePoint();
KAH> while (codePoint != -1)
KAH> {
KAH> - switch (codePoint)
KAH> - {
KAH> + switch (codePoint) {
KAH> // required
KAH> - case CodePoint.FDODSC:
KAH> - while
(reader.getDdmLength() > 6) //we get parameter info til last 6 byte
KAH> + case CodePoint.FDODSC:
KAH> + while (reader.getDdmLength() > 6) //we get parameter
info til last 6 byte
KAH> {
KAH> ... and later ...
KAH> }
KAH> ps = cs;
KAH> stmt.ps = ps;
KAH> - }
KAH> + }
KAH> 4) You have commented out some code. Couldn't you just
KAH> delete it?
I guess I should have.
--
dt
