Re: svn commit: r370815 [1/2] - in /db/derby/code/trunk: ./ java/build/org/apache/derbyBuild/ java/client/org/apache/derby/client/am/ java/client/org/apache/derby/loc/ java/engine/org/apache/derby/iapi/error/ java/engine/org/apache/derby/iapi/reference/ ja...

[Andrew McIntyre]

On Jan 20, 2006, at 6:26 AM, [EMAIL PROTECTED] wrote: New Revision: 370815 URL: http://svn.apache.org/viewcvs?rev=370815&view=rev Log: DERBY-838: Establish an internationalization framework for the network client. Hi David, Sorry I didn't get around to looking at this until after you committed the patch, but: 1. I'm getting a build error in org.apache.derby.iapi.error.StandardException and org.apache.derby.iapi.services.JVMInfo. It looks like you didn't clean up all the references to org.apache.derby.iapi.reference.  1. org.apache.derby.shared.common.i18n? The proposal document (http://wiki.apache.org/db-derby/SharedComponentVersioningGuidelines) says that the package for the common code will be org.apache.derby.common.*. And isn't *.shared.common.* sort of redundant? 2. It's a little weird to have to add a line to splitmessages to have messages show up in the client localized files, but I can't think of a better way either. 3. I know this is a microscopic nit, but the other message files don't contain a hyphen. For consistency, could we not use a hyphen for  the name of the client message file? andrew