[
http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12367710 ]
Rick Hillegas commented on DERBY-819:
-------------------------------------
Hi Anurag,
Thanks for the explanation and the new patch. I believe that Dan's BLOCKERs are
addressed. However, I have a couple suggestions:
1) I found the new comment in SQLExceptionFactory40 a little hard to follow
and I propose the following text, instead:
* This method sets the stack trace of the newly created exception to the
* root cause of the original Throwable.
* Note the following divergence from JDBC3 behavior: When running
* a JDBC3 client, we return EmbedSQLException. That exception class
* overrides Throwable.toString() and strips off the Throwable's class name.
* In contrast, the following JDBC4 implementation returns
* subclasses of java.sql.Exception. These subclasses inherit the behavior
of
* Throwable.toString(). That is, their toString() output includes
* their class name. This will break code which relies on the
* stripping behavior of EmbedSQLSxception.toString().
2) I'm not a big fan of this new test suite for embedded-only tests. I think
that with a little effort, you should be able to make a DerbyJUnitTest subclass
do what you want: for instance, you can customize the main() method of your
subclass and judiciously call DerbyJUnitTest.setClient().
Thanks for your patience. I think we're in the home-stretch here.
> Provide JDBC4 SQLException subclasses support in Embedded driver
> ----------------------------------------------------------------
>
> Key: DERBY-819
> URL: http://issues.apache.org/jira/browse/DERBY-819
> Project: Derby
> Type: Sub-task
> Components: JDBC
> Environment: all
> Reporter: Anurag Shekhar
> Assignee: Anurag Shekhar
> Priority: Minor
> Attachments: .derby-819_2.stat, derby-819-onlyforreview.diff,
> derby-819.diff, derby-819_2.diff, derby-819_3.diff, derby-819_4.diff, stat.out
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
