[ 
http://issues.apache.org/jira/browse/DERBY-965?page=comments#action_12367775 ] 

Bryan Pendleton commented on DERBY-965:
---------------------------------------

I read through your changes and they seem good to me.

It would be nice to have comments in metadata_net.properties explaining the 
encoding, and in DatabaseMetaData.java explaining what's going on with the 
string tokenizers and pointing to the metadata_net.properties since the two 
files are sort of linked at the hip.

It's a bummer about the mixed-version incompatibilities, but I couldn't think 
of any easy way to make them better.


> DatabaseMetadata method supportsResultSetConcurrency returns wrong result on 
> network client
> -------------------------------------------------------------------------------------------
>
>          Key: DERBY-965
>          URL: http://issues.apache.org/jira/browse/DERBY-965
>      Project: Derby
>         Type: Bug
>   Components: Network Server, Network Client
>     Versions: 10.2.0.0
>  Environment: Solaris 10, x86, Sun JDK 1.4.2
>     Reporter: Dag H. Wanvik
>     Assignee: Dag H. Wanvik
>     Priority: Minor
>  Attachments: Main.java, derby965-v1.diff, derby965-v1.stat
>
> The DatabaseMetaData method supportsResultSetConcurrency erroneously
> returns false on the network client for all arguments combination, cf
> the attached repro program. The embedded client returns correct
> results, viz the output:
> org.apache.derby.jdbc.ClientDriver:
> SupportsResultSetConcurrency: TYPE_FORWARD_ONLY,CONCUR_READ_ONLY: false
> SupportsResultSetConcurrency: TYPE_FORWARD_ONLY,CONCUR_UPDATABLE: false
> SupportsResultSetConcurrency: TYPE_SCROLL_INSENSITIVE,CONCUR_READ_ONLY: false
> SupportsResultSetConcurrency: TYPE_SCROLL_INSENSITIVE,CONCUR_UPDATABLE: false
> SupportsResultSetConcurrency: TYPE_SCROLL_SENSITIVE,CONCUR_READ_ONLY: false
> SupportsResultSetConcurrency: TYPE_SCROLL_SENSITIVE,CONCUR_UPDATABLE: false
> org.apache.derby.jdbc.EmbeddedDriver:
> SupportsResultSetConcurrency: TYPE_FORWARD_ONLY,CONCUR_READ_ONLY: true
> SupportsResultSetConcurrency: TYPE_FORWARD_ONLY,CONCUR_UPDATABLE: true
> SupportsResultSetConcurrency: TYPE_SCROLL_INSENSITIVE,CONCUR_READ_ONLY: true
> SupportsResultSetConcurrency: TYPE_SCROLL_INSENSITIVE,CONCUR_UPDATABLE: false
> SupportsResultSetConcurrency: TYPE_SCROLL_SENSITIVE,CONCUR_READ_ONLY: false
> SupportsResultSetConcurrency: TYPE_SCROLL_SENSITIVE,CONCUR_UPDATABLE: false
> Presumably, this is wrong in released versions as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to