[ http://issues.apache.org/jira/browse/DERBY-953?page=all ]
Kristian Waagan updated DERBY-953:
----------------------------------
Attachment: DERBY-953-1a.diff
DERBY-953-1a.stat
Uploaded patch 'DERBY-953-1a.diff' for implementing Statement.isClosed() on
both client and embedded side.
There seems to be a bug in Derby, where Statements are not closed when the
parent connection is. The problem is not seem when testing the client side, but
it might still be the case that the problem do occur "under the hood" on the
server/embedded side. Created issue DERBY-1095 for the bug.
No tests are uploaded yet, as they are dependent on some JUnit changes. Will be
handled as a separate Jira issue.
Derbyall has not been run for this patch, as it is only created two new methods
that return variables.
All tests will be run as part of the testing issue. The new tests will
basically test the existing implementation.
I leave it up to a committer if the patch is delayed until the testing is in
place or not, as the patch is rather simple.
As a side note, it is possible to implement isClosed() to return the intended
values despite the bug described. However, in my opinion, this will only mask
the bug, thus it is better to implement it as it is done in the current patch
and wait for the bug to be fixed.
If we want to have correct results despite the bug, we only need to have
isClosed() check the status of the parent connection before checking it's own
state, but the Statement would actually not be closed even though isClosed()
says it is...
BTW: getResultSetHoldability() is already implemented (JDBC3?).
> Add miscellaneous Statement methods introduced by JDBC 4
> --------------------------------------------------------
>
> Key: DERBY-953
> URL: http://issues.apache.org/jira/browse/DERBY-953
> Project: Derby
> Type: New Feature
> Components: JDBC
> Reporter: Rick Hillegas
> Assignee: Kristian Waagan
> Fix For: 10.2.0.0
> Attachments: DERBY-953-1a.diff, DERBY-953-1a.stat
>
> As described in the JDBC 4 spec, sections 13.1 and 3.1.
> This adds support for new Statement methods added by JDBC4 and not addressed
> by other JIRAs: isClosed() and getResultSetHoldability().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
