[ 
http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12370913 ] 

David Van Couvering commented on DERBY-1097:
--------------------------------------------

Looking at the test source, these look good, although I don't know about having 
an "!" after every assert string.

It's a little odd to me that you run an embedded test under the DerbyNetClient 
framework.

Can't we create a new suite that is the subset of jdbc4 tests that run under 
both the network client and embedded, and then run that subset as a suite under 
the embedded framework?  This would seem better to me than the way this test is 
done.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTest.java-v1, 
> StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging 
> paths regarding how to get connections when running JUnit tests, they are 
> held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to