Hello,
attached svn status output to JIRA Derby-1072.
Thanks
Mayuresh
Rick Hillegas wrote:
Hi Mayuresh,
Thanks for the warning. Looks like Satheesh is reviewing your patch
already. Could you do me a favor and attach the output of "svn status"
to the JIRA so that I can see at a glance what files were changed?
Thanks,
-Rick
Mayuresh Nirhali wrote:
Rick,
I submitted a patch last week for DERBY-1072 which involved
modifications to lot of canon files.
I am hoping that someone would review that patch and commit if it is
okay ?
I thought I should let you know as lot of files I see in your list
are modified.
Thanks
Mayuresh
Rick Hillegas wrote:
Hi Bryan,
Yes, please drop in your changes first. It turns out I'm going to
have to regenerate this patch because a boatload of canon changes
went in over the weekend. Are you planning to commit your changes
today? It would be great if I could merge and regenerate
mid-afternoon San Francisco time.
Thanks,
-Rick
Bryan Pendleton wrote:
In addition, this patch gets rid of many of the jdk16-specific
canons.
Yay!
The only downside is, both you and I want to touch
master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
don't have an easy way to re-make my changes after yours, because I
don't have access to a JDK 1.6 environment yet.
So can I submit my DERBY-349 change first?
thanks,
bryan