[ http://issues.apache.org/jira/browse/DERBY-514?page=all ]
Deepa Remesh updated DERBY-514:
-------------------------------
Attachment: derby-514-patch4-sed.diff
derby-514-patch4-sed.status
Attaching patch4 'derby-514-patch4-sed.diff' which removes the version
information from the canons for upgrade test. The version information is
already checked inside the code - using method 'checkVersion' in UpgradeTester.
So there is no need for it to be in the canon.
I tried using "substitute" of 10.1.x.x but since this is also used in other
parts of test, it did not work. So I had to use "delete" in the sed.properties
file.
I also tried running the test with the jars checked into svn by Andrew and it
runs successfully. There is one small difference from what Andrew suggested in
DERBY-1049. Instead of mapping the svn:external to derby/10.1.1.0, I mapped it
to derby/10.1.This way, we can run the test using different 10.1 versions by
just changing this mapping. I entered the following in the editor opened by
svn:external command:
derby/10.1 https://svn.apache.org/repos/asf/db/derby/jars/10.1.1.0
Then I specified the following in ant.properties file:
derbyTesting.jar.path=C:/deepa/derby_src/workspace1/trunk, where the path
points to the location of my svn workspace files for trunk.
One thing I would like to bring to attention is that the current diff file has
these lines:
Property changes on: tools\testing
___________________________________________________________________
Name: svn:externals
+ derby/10.1 https://svn.apache.org/repos/asf/db/derby/jars/10.1.1.0
I do not know if this will cause problems on other machines when applying this
patch. I would appreciate if Andrew or someone else can confirm this is
expected.
Status of remaining patches pending review/commit:
* derby-514-patch3-v1.diff - Patch which changes the build to use the location
of old jars from properties file
* derby-514-patch4-sed.diff - Patch which updates the canon to remove version
information
Please take a look at the above two patches.
Question:
I also tried running the patch as part of a suite. I created a new suite named
"upgrade". The test has no problems when run using RunSuite. Is this okay or
should I just add the upgrade test to an existing suite like derbylang? If I
don't get an answer, I will submit patch with upgrade test in a new suite.
> Integrate upgrade tests into test suite
> ---------------------------------------
>
> Key: DERBY-514
> URL: http://issues.apache.org/jira/browse/DERBY-514
> Project: Derby
> Type: Test
> Components: Test
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-514-buildfiles-v1.diff, derby-514-buildfiles-v1.status,
> derby-514-patch1-v1.diff, derby-514-patch1-v1.status,
> derby-514-patch2-runtest-v1.diff, derby-514-patch2-runtest-v1.status,
> derby-514-patch3-v1.diff, derby-514-patch3-v1.status,
> derby-514-patch4-sed.diff, derby-514-patch4-sed.status
>
> Currently there are no upgrade tests in the derbyAll suite.
> The upgrade tests java/testing/org/apache/derbyTesting are run by script and
> require that the version to be tested by specified on the command line so
> that the classpath can be changed.
> # runphases old_major old_minor old_engine new_engine
> #
> # e.g.
> #
> # runphases 10 0 c:/derby/10.0.2.1/lib c:/derby/trunk/jars/sane
> Perhaps this script can be rewritten in Java using class loaders and
> previous Derby verssions such as 10.0 and 10.1 be checked in so that this
> testing can be incorporated into the derbyAll test suite.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
