[ 
http://issues.apache.org/jira/browse/DERBY-1291?page=comments#action_12379075 ] 

Daniel John Debrunner commented on DERBY-1291:
----------------------------------------------

>From the comments above it seems that with this patch EmbeddedXADataSource and 
>EmbeddedConnectionPoolDataSource would no longer implement 
>javax.sql.DataSource, is that the case?

If so, this patch would be a regression on the existing contract of 
EmbeddedXADataSource and EmbeddedConnectionPoolDataSource, was there some 
discussion that agreed it was ok to  potentially break applications in this 
case?

Also why have ReferenceableDataSource  and BaseDataSource? What value is there 
in adding BaseDataSource rather than just pushing the methods into 
ReferenceableDataSource  ?

>  Modify DataSource classes of Embedded Driver to seperate DataSource , 
> XADataSource and ConnectionPooledDataSource
> ------------------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1291
>          URL: http://issues.apache.org/jira/browse/DERBY-1291
>      Project: Derby
>         Type: Improvement

>   Components: JDBC
>     Versions: 10.2.0.0
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>  Attachments: derby-1291.diff
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to