[
http://issues.apache.org/jira/browse/DERBY-1323?page=comments#action_12411942 ]
Fernanda Pizzorno commented on DERBY-1323:
------------------------------------------
Review:
The patch looks good. I just have a couple of questions.
1. java/client/org/apache/derby/client/am/ResultSet.java
This check has been added in several places:
+ if (isOnInsertRow_ || !isValidCursorPosition_) {
+ throw new SqlException
+ (agent_.logWriter_,
+ new ClientMessageId(SQLState.NO_CURRENT_ROW));
+ }
Could it be put in a private method?
2. java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURTest.java
Is it really necessary to use reflection?
> Detectability methods rowUpdated, rowInserted, rowDeleted can be called from
> illegal states in both clients
> -----------------------------------------------------------------------------------------------------------
>
> Key: DERBY-1323
> URL: http://issues.apache.org/jira/browse/DERBY-1323
> Project: Derby
> Type: Bug
> Components: JDBC, Network Client
> Versions: 10.2.0.0
> Reporter: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.2.0.0
> Attachments: DERBY-1323-1.diff, DERBY-1323-1.stat, Main.java
>
> Please see enclosed repro.
> These detectability methods fail to check that they can be called in
> some states. In the repro, calls are allowed while on insert row and
> when after last row. These should both fail. Both clients have the
> same problem. All three detectability methods have the same problem.
> (repro only shows it for a subset of the cases).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
