[ http://issues.apache.org/jira/browse/DERBY-1322?page=all ]

Fernanda Pizzorno updated DERBY-1322:
-------------------------------------

    Attachment: derby-1322v2.diff
                derby-1322v2.stat

The attached patch (derby-1322v2.diff) addresses the comments of Dag's review.

In SURTest.java, I agree that s.setCursorName(..) is not necessesary anymore, 
but it has been used in all of the other tests in SURTest.java. I think it is 
ok keep the same pattern as  used previously when adding new tests cases to an 
existing test. That's the reason why I have chosen not to remove it.

Derbyall ran successfully.

> Missing resets of isOnInsertRow state in net client when navigating away via 
> other than ResultSet#next
> ------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1322
>          URL: http://issues.apache.org/jira/browse/DERBY-1322
>      Project: Derby
>         Type: Bug

>   Components: JDBC, Network Client
>     Versions: 10.2.0.0
>     Reporter: Dag H. Wanvik
>     Assignee: Fernanda Pizzorno
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: Repro.java, derby-1322.diff, derby-1322.stat, 
> derby-1322v2.diff, derby-1322v2.stat
>
> Please see the enclosed repro program.
> When attempting the deleteRow, it will fail with SQL state 24000 "no
> current row", since the first() call doesn't properly reset the
> IsOnInsertRow_ state. By inspection of ../am/ResultSet.java I found
> the other positioning calls beside next and moveToCurrentRow to suffer
> the same problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to