[ 
http://issues.apache.org/jira/browse/DERBY-1376?page=comments#action_12415026 ] 

Suresh Thalamati commented on DERBY-1376:
-----------------------------------------

XSLAT.D=Log directory {0} is not empty. Please make sure specified logDevice 
location is correct. 

Check for the log dir  at  the specified location is empty is added as part of 
DERBY-1039 fix.   Although one can create a database at a  log device location 
if the log dir is empty,  I think throwing an error that says  log dir is NOT 
EMPTY  if there are files in the log directory  can be misleading/dangerous.   
Say if the  log directory  at  the user specified location actually  belong s 
to an another database,  if user deletes
the  files by accident  it can lead a inconsistent/corrupt databases.

I understant error message is not a real  protection.  But I think if   we say 
it is not empty ; users may delete the files in hurry to setup a new database.  
My hope is , if they see a error  that says  log directory exists. They may 
specify a different location or  make sure  that no 
other database is  using the  specified log location path before deleting the 
log directory. 


Thanks
-suresht










 




> File java/engine/org/apache/derby/loc/messages_en.properties - Message XSLAT.D
> ------------------------------------------------------------------------------
>
>          Key: DERBY-1376
>          URL: http://issues.apache.org/jira/browse/DERBY-1376
>      Project: Derby
>         Type: Improvement

>   Components: Localization
>     Versions: 10.1.2.4
>  Environment: Text for exceptions
>     Reporter: Halley Pacheco de Oliveira
>     Priority: Minor
>      Fix For: 10.1.2.4

>
> The message XSLAT.D (String LOG_SEGMENT_EXIST = "XSLAT.D";) states:
> XSLAT.D=Log directory {0} exists. Please make sure specified logDevice 
> location is correct.
> But it seems by the source code that the problem is not that this directory 
> exists, but the fact that it is not empty (// make sure log directory is 
> empty, in LogToFile.java). So it seems to me that the following message would 
> be better:
> XSLAT.D=Log directory {0} is not empty. Please make sure specified logDevice 
> location is correct.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to