[ http://issues.apache.org/jira/browse/DERBY-1002?page=comments#action_12416012 ]
Kathey Marsden commented on DERBY-1002: --------------------------------------- Deepa said: | Patch 1 and 2 have been committed to trunk as well as 10.1 branch. Andrew said: | This has been partially fixed in 10.1.3. What hasn't gone to 10.1.x? > Check that DRDAStatement and DRDAResultSet states are reset when they are > re-used > --------------------------------------------------------------------------------- > > Key: DERBY-1002 > URL: http://issues.apache.org/jira/browse/DERBY-1002 > Project: Derby > Type: Bug > Components: Network Server > Reporter: Deepa Remesh > Fix For: 10.2.0.0, 10.1.3.0 > Attachments: derby1002-patch1-draft1.diff, derby1002-patch1-draft1.status, > derby1002-patch1-v1.diff, derby1002-patch1-v1.status, > derby1002-patch2-v2.diff, derby1002-patch2-v2.status, derby1002.java > > Network server re-uses DRDAStatement and DRDAResultSet objects when client > sends a request with same section number. When re-using DRDAStatement, it's > close() method is called which inturn calls close() method of DRDAResultSet. > For re-use to work properly, we have to ensure the states of these objects > are reset. This is not a bug but it is an area for possible improvements like: > * The reset of all states are not in the close() methods. The states get > re-initialized at different places in the code. Fo example, in case of > DRDAResultSet, they get initialized in some other DRDAStatement methods - > like addResultSet, setRsDefaultOptions, setOPNQRYOptions, setQueryOptions > etc. It will be good to have all resets in one method. > * The method name "close" is confusing since it is also called when objects > get re-used. For clarity, it may be good to have a method named reset(). And > then have the close method call reset. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
