[ http://issues.apache.org/jira/browse/DERBY-1002?page=comments#action_12416016 ]
Deepa Remesh commented on DERBY-1002: ------------------------------------- The actual issue reported in this JIRA is fixed. There were some code cleanup TODOs as noted in previous comment: * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object. * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called. I had not resolved this issue in trunk or 10.1 because of these TODO items. To avoid confusion, I will mark this issue fixed and open a minor issue for code cleanup. > Check that DRDAStatement and DRDAResultSet states are reset when they are > re-used > --------------------------------------------------------------------------------- > > Key: DERBY-1002 > URL: http://issues.apache.org/jira/browse/DERBY-1002 > Project: Derby > Type: Bug > Components: Network Server > Reporter: Deepa Remesh > Fix For: 10.2.0.0, 10.1.3.0 > Attachments: derby1002-patch1-draft1.diff, derby1002-patch1-draft1.status, > derby1002-patch1-v1.diff, derby1002-patch1-v1.status, > derby1002-patch2-v2.diff, derby1002-patch2-v2.status, derby1002.java > > Network server re-uses DRDAStatement and DRDAResultSet objects when client > sends a request with same section number. When re-using DRDAStatement, it's > close() method is called which inturn calls close() method of DRDAResultSet. > For re-use to work properly, we have to ensure the states of these objects > are reset. This is not a bug but it is an area for possible improvements like: > * The reset of all states are not in the close() methods. The states get > re-initialized at different places in the code. Fo example, in case of > DRDAResultSet, they get initialized in some other DRDAStatement methods - > like addResultSet, setRsDefaultOptions, setOPNQRYOptions, setQueryOptions > etc. It will be good to have all resets in one method. > * The method name "close" is confusing since it is also called when objects > get re-used. For clarity, it may be good to have a method named reset(). And > then have the close method call reset. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
