[ http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12421028 ]
Andrew McIntyre commented on DERBY-982: --------------------------------------- Hi Kristian, Thanks for the review! I think that the changes to sysinfo are correct, but the test needs to be revised. The approach I plan to take with the next version of this patch will compare the results for the version from the sysinfo API with the results for the version info as returned from DatabaseMetadata. I don't want to introduce another dependency on a version-specific master file, and I also do not want to introduce a test that exercises a tautology. That is, I don't want to directly compare the information used by sysinfo to generate its version information (the properties files in o.a.d.info) with itself. So, my plan for the next version of this test will be to compare the version information obtained through JDBC's DatabaseMetadata with the information obtained via the sysinfo API. I believe this is a proper test of the sysinfo API: that the version information for a specific version of Derby obtained through the sysinfo API is equivalent to the version obtained through other means. This will improve coverage for our testing of the sysinfo API (currently at 0%) as well as verify that the values obtained via the DatabaseMetadata interface are correct. Thoughts? andrew > sysinfo api does not provide genus name for client > -------------------------------------------------- > > Key: DERBY-982 > URL: http://issues.apache.org/jira/browse/DERBY-982 > Project: Derby > Type: Bug > Components: Tools > Versions: 10.1.2.1 > Reporter: Kathey Marsden > Assignee: Andrew McIntyre > Fix For: 10.2.0.0 > Attachments: derby-982.diff, derby-982_v2.diff > > The sysinfo api does not provide access to the genus name for client to allow > applications to retrieve information from sysinfo about the client > information. > http://db.apache.org/derby/javadoc/publishedapi/org/apache/derby/tools/sysinfo.html > Note: Currently ProductGenusNames has a genus name for network server but > network server is closely tied to the engine so should always have the same > version. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
